Skip to content

fix(weather): allow using manually configured coordinates - #3734

Open
js0ny wants to merge 1 commit into
noctalia-dev:mainfrom
js0ny:fix/manual-weather-location
Open

fix(weather): allow using manually configured coordinates#3734
js0ny wants to merge 1 commit into
noctalia-dev:mainfrom
js0ny:fix/manual-weather-location

Conversation

@js0ny

@js0ny js0ny commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR publishes manually configured latitude and longitude through LocationService when automatic location and address lookup are disabled.

Motivation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Related Issue

No related issues

Testing

$ NOSYSBASHLOGOUT=1 just test 
Ok:                66  
Fail:              0 

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

image

If only coordinates given, show the raw lat, lng on weather panel.

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I will update end-user documentation after merge, or this PR does not change user-facing configuration or behavior.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Additional Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant