test: fix flaky http2-dispatcher WebSocket upgrade tests#5304
Merged
Conversation
The CONNECT/WebSocket upgrade server handlers used stream.respond()
with the default endStream: true, immediately closing the tunnel from
the server side. This caused ECONNRESET because the HTTP/2 session
would tear down the TCP connection before queued requests could
complete or before test assertions could verify socket state.
Changes:
- Dispatcher#Upgrade: respond with { endStream: false } to keep the
CONNECT tunnel open, move socket error handler before assertions
- Dispatcher#Upgrade resumes queued requests: same endStream fix,
add server-side end handler to close tunnel when client ends,
move error handler before assertions, simplify try-finally cleanup
Fixes: #5195
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5304 +/- ##
==========================================
+ Coverage 93.23% 93.24% +0.01%
==========================================
Files 110 110
Lines 36575 36575
==========================================
+ Hits 34099 34106 +7
+ Misses 2476 2469 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trivikr
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CONNECT/WebSocket upgrade server handlers used stream.respond()
with the default endStream: true, immediately closing the tunnel from
the server side. This caused ECONNRESET because the HTTP/2 session
would tear down the TCP connection before queued requests could
complete or before test assertions could verify socket state.
Changes:
CONNECT tunnel open, move socket error handler before assertions
add server-side end handler to close tunnel when client ends,
move error handler before assertions, simplify try-finally cleanup
Fixes: #5195