[7.x] fix: support Node 26 and legacy global dispatcher#5319
Draft
mcollina wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v7.x #5319 +/- ##
==========================================
- Coverage 92.89% 92.84% -0.06%
==========================================
Files 112 113 +1
Lines 35828 35964 +136
==========================================
+ Hits 33283 33391 +108
- Misses 2545 2573 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport Node 26 support and the legacy global dispatcher mirroring added in undici 8.
Changes
test/node-testthrough a dedicated diagnostic runner on Node 26test/node-test/client-errors.jsundici.globalDispatcher.2undici.globalDispatcher.1Dispatcher1Wrapperand add typings/tests for itallowH2: falsefor legacy v1 dispatcher consumersTesting
node --test test/node-test/global-dispatcher-version.jsnode --test test/node-test/client-errors.jsnpm run test:typescriptnpx eslint index.js lib/global.js lib/dispatcher/dispatcher1-wrapper.js test/node-test/global-dispatcher-version.js test/node-test/client-errors.js scripts/run-node-test-ci.mjsnode scripts/run-node-test-ci.mjs