unslop(web-hf): strip narrating comments/JSDoc and inline a one-use handler in hugging_face and packages UI - #4233
Merged
Merged
Conversation
…andler in hugging_face and packages UI
…raction, useEffect-derived, zustand selectors, raw MUI)
…ction, useEffect-derived, zustand selectors, raw MUI)
…ndlers, over-abstraction, redundant types)
…straction, useEffect-derived, zustand selectors, raw MUI)
georgi
enabled auto-merge (squash)
July 11, 2026 06:06
georgi
disabled auto-merge
July 11, 2026 06:07
…ers, over-abstraction, useEffect-derived, zustand selectors, raw MUI)
…raction, useEffect-derived, zustand selectors, raw MUI)
…action, useEffect-derived, zustand selectors, raw MUI)
… workspace, miniapps
…-abstraction, useEffect-derived, zustand selectors, raw MUI)
…over-abstraction, useEffect-derived, zustand selectors, raw MUI)
…action, useEffect-derived, zustand selectors, raw MUI)
georgi
commented
Jul 11, 2026
georgi
left a comment
georgi
left a comment
Collaborator
Author
There was a problem hiding this comment.
This PR touches 394 files — too large for a thorough line-by-line review. CI is still running and "Component visual tests" has already failed.
The changes are almost entirely mechanical (removing narrating comments, JSDoc, design-token migration breadcrumbs, and blank lines), with ~47 files containing minor code simplifications.
Suggestion: Consider splitting this into smaller PRs (e.g., by directory — components/node/, components/sketch/, components/properties/, etc.) to make review tractable and reduce merge conflict surface with other open PRs.
Will revisit once CI is fully green and stable.
Generated by Claude Code
…raction, useEffect-derived, zustand selectors)
…action, redundant types)
…straction, useEffect-derived, zustand selectors, raw MUI)
…ction, useEffect-derived, zustand selectors, raw MUI)
…cks, over-abstraction)
…raction, redundant types)
… over-abstraction, redundant types)
…e checks, over-abstraction, dead handlers)
…, over-abstraction, redundant types)
…ndlers, over-abstraction, redundant types)
…-abstraction, redundant types)
…-abstraction from provider nodes
…nslop The useAddToGroup/useDynamicProperty hooks switched from a shallow object selector to a direct single-value selector. The tests mocked useNodes with mockReturnValue, ignoring the selector, so the hooks received the mock object instead of the function. Apply the selector to a mock state, matching the codebase's canonical Zustand-hook mock pattern.
georgi
enabled auto-merge (squash)
July 11, 2026 15:13
…e-refactor-yp5ahn # Conflicts: # packages/agents/src/agent.ts # web/src/hooks/useAutosave.ts # web/src/lib/dragdrop/index.ts # web/src/lib/dragdrop/useDraggable.ts # web/src/serverState/useAssetUpdate.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.