fix(studio): six review fixes for the beginner shell - #4764
Merged
Conversation
- Flush the storyboard autosave on unmount (same flush chain the script sync already has), so editing a field and immediately leaving the page no longer loses the pending debounced edit. - Pin the Studio assistants to the curated director model: the shell forces GlobalChatStore.selectedModel while mounted and restores the user's own selection on unmount, so workspace chat is untouched. - Serialize the two creation paths: both cards disable while either is creating, and the handlers guard on a ref, so double-activation can't create multiple projects or race the navigation. - A failed credits request now reads "credits unavailable" (chip) and a retry banner (account page) instead of displaying a full balance. - Mount useDocumentUndoShortcuts in both Studio editors so the advertised Cmd-Z / Cmd-Shift-Z shortcuts actually work. - Scope recent timelines like storyboards and scripts (no project filter), so the merged recent-projects list is consistent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011GwuPTt5T1sLkmpwWUt2N2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #4758/#4760: fixes the six issues found in review of the Studio shell.
useStoryboardServerSyncnow flushes the pending debounced save on unmount using the same flush chainuseScriptServerSyncalready has (in-flight saves set a flush flag; otherwise a finalsave(true)runs). Leaving the page right after an edit no longer drops it.useStudioAssistantModel(mounted inStudioShell) pinsGlobalChatStore.selectedModelto the curated director model while any Studio page is mounted and restores the user's own selection on unmount, so workspace chat keeps its model.unavailable(query.isError); the header chip reads "credits unavailable" (neutral color) and the account page shows a retry banner, instead of displaying the full grant.useDocumentUndoShortcutswithactive: true, wired to their stores' undo/redo.useTimelines()without the project filter, matching how storyboards and scripts are listed.Verification
webtypecheck and eslint pass on top of the merged credits work.🤖 Generated with Claude Code
https://claude.ai/code/session_011GwuPTt5T1sLkmpwWUt2N2
Generated by Claude Code