ci: stop cancelled Ring 1 runs from failing the Fly deploy - #4784
Merged
Conversation
Two merges landing on main within a few minutes cancelled the earlier commit's User Journeys run (cancel-in-progress keyed on the ref), and fly-deploy's gate treats a cancelled reliability-ring1 as a hard failure — so a superseded commit produced a red deploy. - user-journeys.yml: keep superseded runs on main alive, matching docker.yml's expression. Every main commit's Ring 1 now reaches a conclusion of its own, which is what the gate reads. - fly-deploy.yml: when an upstream is red or cancelled for a commit main has already moved past, skip the deploy (deploy=false output) instead of failing. The newer commit's own run does the releasing. Also fold timed_out into the terminal conclusions the gate reacts to, rather than polling until the 65-minute job timeout. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGkCEj3kPc4QMCxBPGo95p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Run 31256065058 failed on its first poll:
user-journeys.ymlcarriedcancel-in-progress: trueon a group keyed by ref, so two merges landing onmainwithin three minutes (97f053eat 11:47,8cdf606at 11:50) cancelled the earlier commit'sreliability-ring1run.fly-deploy.yml's gate reads a per-commit conclusion and treatscancelledas a hard failure — so a commit that was merely superseded produced a red deploy. The same pattern shows up repeatedly in the run history (four consecutive cancellations on 2026-08-07).Changes
user-journeys.yml— don't cancel superseded runs onmain, using the same expressiondocker.ymlalready uses. Every main commit's Ring 1 now reaches a conclusion of its own, which is exactly what the gate polls for. PR branches and tags still cancel.fly-deploy.yml— when an upstream is red or cancelled for a commitmainhas already moved past, skip the deploy instead of failing it. The gate emits adeployoutput thatdeploy'sifrequires, so a superseded commit ends green-and-skipped rather than red, and the newer commit's own run does the releasing.timed_outinto the terminal conclusions the gate reacts to, instead of polling on until the 65-minute job timeout..github/workflows/README.md— record why Ring 1 doesn't cancel onmain, since that's the non-obvious coupling.Verification
Both workflow files parse. The gate script was extracted and exercised against a stubbed
ghacross four cases:deploy=truedeploy=false, noticeA genuinely failing Ring 1 on the tip of
mainstill blocks the deploy — only the superseded case changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01LGkCEj3kPc4QMCxBPGo95p
Generated by Claude Code