chore: expect aztec-packages private kernel circuits not to compile - #13581
Merged
TomAFrench merged 2 commits intoSep 1, 2026
Merged
Conversation
`BoundedVec::from_parts_unchecked` is removed by this branch, and the pinned aztec-packages commit still calls it throughout private-kernel-lib.
They cannot compile while this branch removes `BoundedVec::from_parts_unchecked`.
TomAFrench
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
Four aztec-packages jobs fail on #13571. All four have the same root cause: the branch removes the deprecated
BoundedVec::from_parts_unchecked, and the pinned aztec-packages commit (28549d2) still calls it inprivate-kernel-lib— invalidate_side_effect_counters.nrand across theprivate_kernel_reset/tail_validatorstests.Check external repo - .../crates/private-kernel-lib(job):External repo compilation and execution reportsforprivate-kernel-inner,private-kernel-resetandprivate-kernel-reset-tail, which all buildprivate-kernel-lib.Summary of Changes
private-kernel-lib.failures.jsonltoprivate-kernel-lib.failures.jsonl.does_not_compile, exactly as the check script suggests..github/benchmark_projects.yml, which has no expected-failure mechanism of its own. TheReportsmatrix is built from that file'sprojectskeys, so those legs simply stop running; nothing else in the repo references them by name.Both are keyed to the same follow-up: restore them when
AZ_COMMITis bumped to an aztec-packages revision that usesBoundedVec::from_parts.private-kernel-libis the only aztec-packages project affected —from_parts_uncheckedappears nowhere else undernoir-projectsat the pinned commit, and thetypes,blob,rollup-lib,aztec-nrandnoir-contractsexternal-repo checks are green on the head commit.User Documentation
Check one:
PR Checklist
cargo fmton default settings.Created by claudebox · group:
slackbot· requested by Tom (@TomAFrench) · Slack thread