Skip to content

chore: expect aztec-packages private kernel circuits not to compile - #13581

Merged
TomAFrench merged 2 commits into
ab/remove-deprecated-codefrom
cb/expect-private-kernel-lib-not-to-compile
Sep 1, 2026
Merged

chore: expect aztec-packages private kernel circuits not to compile#13581
TomAFrench merged 2 commits into
ab/remove-deprecated-codefrom
cb/expect-private-kernel-lib-not-to-compile

Conversation

@AztecBot

@AztecBot AztecBot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Problem Resolved

Four aztec-packages jobs fail on #13571. All four have the same root cause: the branch removes the deprecated BoundedVec::from_parts_unchecked, and the pinned aztec-packages commit (28549d2) still calls it in private-kernel-lib — in validate_side_effect_counters.nr and across the private_kernel_reset / tail_validators tests.

Check external repo - .../crates/private-kernel-lib (job):

error: Could not resolve 'from_parts_unchecked' in path
    ┌─ src/components/private_call_data_validator/validate_side_effect_counters.nr:534:48
...
Error: external library tests couldn't be compiled.
You could rename '.github/critical_libraries_status/.../private-kernel-lib.failures.jsonl' to '...does_not_compile' if it's expected that the external library can't be compiled.

External repo compilation and execution reports for private-kernel-inner, private-kernel-reset and private-kernel-reset-tail, which all build private-kernel-lib.

Summary of Changes

  • Renames private-kernel-lib.failures.jsonl to private-kernel-lib.failures.jsonl.does_not_compile, exactly as the check script suggests.
  • Comments out the three private kernel entries in .github/benchmark_projects.yml, which has no expected-failure mechanism of its own. The Reports matrix is built from that file's projects keys, so those legs simply stop running; nothing else in the repo references them by name.

Both are keyed to the same follow-up: restore them when AZ_COMMIT is bumped to an aztec-packages revision that uses BoundedVec::from_parts.

private-kernel-lib is the only aztec-packages project affected — from_parts_unchecked appears nowhere else under noir-projects at the pinned commit, and the types, blob, rollup-lib, aztec-nr and noir-contracts external-repo checks are green on the head commit.

User Documentation

Check one:

  • No user documentation needed.
  • Documented in docs/.
  • [For Experimental Features] Documentation tracking issue created:

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Created by claudebox · group: slackbot · requested by Tom (@TomAFrench) · Slack thread

`BoundedVec::from_parts_unchecked` is removed by this branch, and the pinned aztec-packages commit still calls it throughout private-kernel-lib.
They cannot compile while this branch removes `BoundedVec::from_parts_unchecked`.
@AztecBot AztecBot changed the title chore: expect aztec-packages private-kernel-lib not to compile chore: expect aztec-packages private kernel circuits not to compile Sep 1, 2026
@TomAFrench
TomAFrench marked this pull request as ready for review September 1, 2026 14:17
@TomAFrench
TomAFrench merged commit 92fd699 into ab/remove-deprecated-code Sep 1, 2026
130 checks passed
@TomAFrench
TomAFrench deleted the cb/expect-private-kernel-lib-not-to-compile branch September 1, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants