fix: reject all-zeroes mask when limit < Range - #60
Open
asterite wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Resolved
Resolves https://github.com/noir-lang/noir-library-claude/issues/10
Resolves #59
Summary of Changes
In
boundary_check, if__boundary_checkreturned an all-zeroes array it didn't produce an assertion failure regardless of the value oflimit. The fix is to replace one of the last assertions done withassert_eq(r[Range - 1], (limit < Range) as Field)which means that the last position is 0 is the limit is past the range, or 1 if it's before the range (the previous assertions make sure it's always a chain of zeroes followed by a chain of ones).I also included tests for
boundary_checkas it wasn't tested, and tests for the "verify this unconstrained value" part of the function, which is nowassert_boundary_mask.PR Checklist
cargo fmton default settings.