feat(diagnostics): expose structured diagnostics for Python supervisors#87
feat(diagnostics): expose structured diagnostics for Python supervisors#87SequeI wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces structured diagnostics for Python clients by adding stderr parsing and diagnostic reporting capabilities, exposing new Python bindings such as session_diagnostics and diagnostics. The review feedback highlights critical compilation and compatibility issues: the invalid Python::attach API should be replaced with Python::with_gil, unstable let_chains in src/stderr_observation.rs must be rewritten using nested if let blocks for stable Rust compatibility, and the deprecated PyModule::import should be updated to py.import.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Add PyO3 bindings for nono #1171 structured diagnostics: error diagnostic_code and remediation attrs, proxy startup diagnostics, exec session reports with stderr translation, and merge helpers. Signed-off-by: Aleksy Siek <aleksy@alwaysfurther.ai>
2 participants
Add PyO3 bindings for nono #1171 structured diagnostics: error diagnostic_code and remediation attrs, proxy startup diagnostics, exec session reports with stderr translation, and merge helpers.
Waiting on nolabs-ai/nono#1171 to land first before this can be merged
Linked Issue
Closes #
Summary
Checklist
_nono_py.pyi) are updated if Rust API changed