Make sure we ask for UV asap for faster image display#699
Draft
maxkadel wants to merge 3 commits into
Draft
Conversation
maxkadel
marked this pull request as ready for review
July 14, 2026 13:26
Member
Author
|
I tried adding this to Hyrax, but it interferes with the Batch Update javascript. I don't think Hyku uses batch update - see samvera/hyrax#7538 |
ShanaLMoore
approved these changes
Jul 14, 2026
maxkadel
marked this pull request as draft
July 14, 2026 16:11
Member
Author
|
Converting to draft until we confirm whether Batch Upload may be impacted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story
Refs https://github.com/notch8/dev-ops/issues/1393
IIIF viewer javascript is pre-loaded on work show pages, and no longer waits to start fetching it until after the javascript is fully executed
Fixes
There is a general perception that Hyrax and Hyku are slow, and some of this comes from IIIF viewers taking awhile to show images. By default, the viewers are "above the fold" on work pages, so if they take a long time to render an image, the impression it gives is that the overall application is slow, not just that the viewer is slow.
This frontloads getting the iiif viewer javascript, and not waiting for the whole application javascript to execute prior to trying to fetch the viewer javascript.
Tested on a staging environment for a Hyku knapsack and shaved 3 seconds off of loading time.
Summary
Present tense short summary (50 characters or less)
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
Choose from:
notes-bugfixBug FixesChanges proposed in this pull request: