Skip to content

fix: never abandon a recursive watch, report what failed instead #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinpitt wants to merge 3 commits into
base: main
Choose a base branch
from
+301 −44
Open

fix: never abandon a recursive watch, report what failed instead #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2155881
inotify: split out the recursive walk's per-failure policy
martinpitt Aug 6, 2026
f351fce
fix: never abandon a recursive watch, report what failed instead
martinpitt Aug 6, 2026
1050c2b
inotify: report the subtrees a recursive watch could not walk into
martinpitt Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions notify/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@
- PERF: [kqueue] avoid filesystem walks for recursive kqueue unwatch
- FEATURE: add `Watcher::watch_with` to pass per-path settings, and `WatchPathConfig::with_dereference_symlinks` to watch a symbolic link itself instead of its destination, which also makes a dangling link watchable [#255]
- FIX: [poll] detect subsecond file mtime changes without content hashing
- FIX: [inotify] never abandon a recursive watch, report what failed instead [#970]
- FIX: [inotify] report the directories a recursive watch could not walk into, rather than leaving their subtrees silently unwatched [#970]

[#255]: https://github.com/notify-rs/notify/issues/255
[#930]: https://github.com/notify-rs/notify/pull/930
[#935]: https://github.com/notify-rs/notify/issues/935
[#958]: https://github.com/notify-rs/notify/pull/958
[#970]: https://github.com/notify-rs/notify/pull/970

## notify 9.0.0-rc.4 (2026-05-02)

Expand Down
Loading