Open
Conversation
lbrndnr
reviewed
Apr 13, 2026
Collaborator
lbrndnr
left a comment
lbrndnr
left a comment
There was a problem hiding this comment.
Very cool! I've added a couple of minor comments :)
| s.replace(',', "\\,").replace('=', "\\=").replace(' ', "\\ ") | ||
| } | ||
|
|
||
| fn build_tag_str(tags: &HashMap<String, String>) -> String { |
Collaborator
There was a problem hiding this comment.
This function gets used only push_all. I think it would be cleaner if this was nested within push_all.
|
|
||
|
|
||
|
|
||
| fn escape_tag(s: &str) -> String { |
Collaborator
There was a problem hiding this comment.
I think we could nest this into build_tag_str.
| fn collect_line_protocol(tag_str: &str, timestamp_ns: u128) -> Result<String> { | ||
| let mut lines: Vec<String> = Vec::new(); | ||
|
|
||
| { |
Collaborator
There was a problem hiding this comment.
Don't think this closure is necessary, i.e. the extraneous '{' and '}'
| } | ||
| } | ||
|
|
||
| { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the slightly misused prometheus with a solution mabye better suited for one-off measurements, InfluxDB. Further, a NESQUIC_RUN_LABEL has been added to the script, which enables the user to then select runs in grafana to view.