fix: Stop using return-type assignability for generic call matching - #989
Merged
Merged
Conversation
dtchepak
approved these changes
Aug 9, 2026
This was referenced Aug 11, 2026
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #974
Closes #977
This is the proper fix to the original issue. We have a plenty of scenarios when we have to see if return types are cross-compatible. That makes sense for parameters, but not for the return types. For the return types we don't need to support assignable types and that breaks the scenario in the issue. Fix it by passing an explicit flag and disable equivalency test for return types, while keeping it for parameters.
I will also make a follow up PR to name assignability check more strict (to better cater for in/out and be safer).