Skip to content

refactor(notebook): remove tool availability checks#878

Merged
rgbkrk merged 2 commits intomainfrom
quill/raleigh-v7
Mar 16, 2026
Merged

refactor(notebook): remove tool availability checks#878
rgbkrk merged 2 commits intomainfrom
quill/raleigh-v7

Conversation

@rgbkrk
Copy link
Copy Markdown
Member

@rgbkrk rgbkrk commented Mar 16, 2026

Summary

Removes vestigial tool availability checks from the notebook frontend. The daemon now handles all tool detection (uv, deno) and bootstrapping during kernel launch, making the frontend-side "tool not found" banners redundant.

Changes:

  • Remove Tauri commands: check_uv_available, check_deno_available
  • Remove frontend state tracking: uvAvailable, denoAvailable
  • Remove "Tool not found" banners from dependency headers
  • Drop unused kernel-env dependency from notebook crate
  • Simplify environment type detection logic in App.tsx

Protocol types (CheckToolAvailable, ToolAvailable) remain in the daemon for potential future use (e.g., onboarding UI).

Verification

  • No "uv not found" or "Deno not found" banners appear in the UI
  • UV dependency management works as before
  • Deno kernel launch works as before
  • Environment detection (uv/conda/pixi) still selects correct panels

PR submitted by @rgbkrk's agent, Quill

…ontend

Tool availability (uv, deno) is now checked and bootstrapped entirely by the
daemon during kernel launch. Frontend "not found" banners were proactive UX hints
that duplicated daemon-side logic. Removed:

- Tauri commands: check_uv_available, check_deno_available
- Frontend state: uvAvailable, denoAvailable
- "Tool not found" banners from DependencyHeader and DenoDependencyHeader
- Unused kernel-env dependency from notebook crate

Simplifies frontend and reduces IPC overhead. Protocol types (CheckToolAvailable,
ToolAvailable) remain in place for future use.
@github-actions github-actions bot added frontend Webview, React, TypeScript UI quill PR authored by Quill Agent 🦆 labels Mar 16, 2026
@nteract nteract deleted a comment from Copilot AI Mar 16, 2026
@rgbkrk rgbkrk requested a review from Copilot March 16, 2026 15:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes frontend-side UV/Deno tool availability checks and related UI banners in the notebook app, relying on the daemon to handle tool detection/bootstrapping during kernel launch.

Changes:

  • Removed Tauri commands check_uv_available and check_deno_available from the notebook crate.
  • Removed frontend uvAvailable / denoAvailable state and “tool not found” banners from dependency headers.
  • Dropped the unused kernel-env dependency from crates/notebook.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/notebook/src/uv_env.rs Removes notebook-side UV availability helper and updates module docs to reflect daemon ownership.
crates/notebook/src/lib.rs Deletes the two Tauri commands and removes them from the invoke handler list.
crates/notebook/Cargo.toml Removes the kernel-env dependency from the notebook crate.
apps/notebook/src/hooks/useDependencies.ts Eliminates uvAvailable state and the check_uv_available invoke on mount.
apps/notebook/src/hooks/useDenoDependencies.ts Eliminates denoAvailable state and the check_deno_available invoke on mount.
apps/notebook/src/components/DependencyHeader.tsx Removes the “uv not found” banner and associated prop wiring.
apps/notebook/src/components/DenoDependencyHeader.tsx Removes the “Deno not found” banner and stops gating UI on availability.
apps/notebook/src/App.tsx Removes availability plumbing and simplifies env-type selection logic accordingly.
Cargo.lock Updates lockfile after removing kernel-env from crates/notebook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@rgbkrk rgbkrk enabled auto-merge (squash) March 16, 2026 16:09
@rgbkrk rgbkrk disabled auto-merge March 16, 2026 16:36
@rgbkrk rgbkrk merged commit a6795a5 into main Mar 16, 2026
22 of 24 checks passed
@rgbkrk rgbkrk deleted the quill/raleigh-v7 branch March 16, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Webview, React, TypeScript UI quill PR authored by Quill Agent 🦆

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants