refactor(notebook): remove tool availability checks#878
Merged
Conversation
…ontend Tool availability (uv, deno) is now checked and bootstrapped entirely by the daemon during kernel launch. Frontend "not found" banners were proactive UX hints that duplicated daemon-side logic. Removed: - Tauri commands: check_uv_available, check_deno_available - Frontend state: uvAvailable, denoAvailable - "Tool not found" banners from DependencyHeader and DenoDependencyHeader - Unused kernel-env dependency from notebook crate Simplifies frontend and reduces IPC overhead. Protocol types (CheckToolAvailable, ToolAvailable) remain in place for future use.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes frontend-side UV/Deno tool availability checks and related UI banners in the notebook app, relying on the daemon to handle tool detection/bootstrapping during kernel launch.
Changes:
- Removed Tauri commands
check_uv_availableandcheck_deno_availablefrom the notebook crate. - Removed frontend
uvAvailable/denoAvailablestate and “tool not found” banners from dependency headers. - Dropped the unused
kernel-envdependency fromcrates/notebook.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
crates/notebook/src/uv_env.rs |
Removes notebook-side UV availability helper and updates module docs to reflect daemon ownership. |
crates/notebook/src/lib.rs |
Deletes the two Tauri commands and removes them from the invoke handler list. |
crates/notebook/Cargo.toml |
Removes the kernel-env dependency from the notebook crate. |
apps/notebook/src/hooks/useDependencies.ts |
Eliminates uvAvailable state and the check_uv_available invoke on mount. |
apps/notebook/src/hooks/useDenoDependencies.ts |
Eliminates denoAvailable state and the check_deno_available invoke on mount. |
apps/notebook/src/components/DependencyHeader.tsx |
Removes the “uv not found” banner and associated prop wiring. |
apps/notebook/src/components/DenoDependencyHeader.tsx |
Removes the “Deno not found” banner and stops gating UI on availability. |
apps/notebook/src/App.tsx |
Removes availability plumbing and simplifies env-type selection logic accordingly. |
Cargo.lock |
Updates lockfile after removing kernel-env from crates/notebook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes vestigial tool availability checks from the notebook frontend. The daemon now handles all tool detection (uv, deno) and bootstrapping during kernel launch, making the frontend-side "tool not found" banners redundant.
Changes:
check_uv_available,check_deno_availableuvAvailable,denoAvailablekernel-envdependency from notebook crateProtocol types (CheckToolAvailable, ToolAvailable) remain in the daemon for potential future use (e.g., onboarding UI).
Verification
PR submitted by @rgbkrk's agent, Quill