Add support for validation sets and callbacks on lgbm learner#251
Merged
Conversation
gppeixoto
previously approved these changes
Apr 22, 2026
fadb444 to
c74f4ec
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Todo list
Background context
The
lgbm_regression_learnerdid not support validation sets or callbacks, limiting the ability to use early stopping and monitor training progress — features already available in the classification counterpart (lgbm_classification_learner).Continuation of #249 given dependencies unblocked resolution by #250
Description of the changes proposed in the pull request
valid_dfsandcallbacksparameters tolgbm_regression_learner, matching the interface oflgbm_classification_learnervalid_dfsis provided, create LightGBM validation datasets (with proper feature names and weights) for early-stopping supportcallbacksthrough tolgbm.trainfor iteration-level hooks (e.g.lgbm.early_stopping,lgbm.log_evaluation)targetcolumncoverageso it's compatible with newer versions ofnumbaWhere should the reviewer start?
src/fklearn/training/regression.py— the changes tolgbm_regression_learner