Skip to content

More datamanagers use!#3750

Merged
lferran merged 3 commits into
mainfrom
more-datamanagers-use
Jun 22, 2026
Merged

More datamanagers use!#3750
lferran merged 3 commits into
mainfrom
more-datamanagers-use

Conversation

@lferran

@lferran lferran commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@lferran lferran requested review from a team as code owners June 22, 2026 09:12
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (9962c61) to head (49d20bf).

Files with missing lines Patch % Lines
.../src/nucliadb/common/datamanagers/conversations.py 97.72% 1 Missing ⚠️
...ucliadb/src/nucliadb/ingest/fields/conversation.py 94.11% 1 Missing ⚠️
nucliadb/src/nucliadb/reader/api/v1/resource.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3750      +/-   ##
==========================================
+ Coverage   85.46%   85.47%   +0.01%     
==========================================
  Files         563      564       +1     
  Lines       48810    48850      +40     
  Branches    14351    14351              
==========================================
+ Hits        41714    41754      +40     
- Misses       6462     6463       +1     
+ Partials      634      633       -1     
Flag Coverage Δ
nidx 79.72% <ø> (ø)
nucliadb 74.22% <94.87%> (+0.05%) ⬆️
nucliadb-ingest 43.78% <75.64%> (+0.04%) ⬆️
nucliadb-reader 43.78% <89.74%> (+0.06%) ⬆️
nucliadb-search 55.00% <79.48%> (+0.03%) ⬆️
nucliadb-standalone 46.15% <23.07%> (-0.03%) ⬇️
nucliadb-train 44.76% <23.07%> (-0.03%) ⬇️
nucliadb-writer 47.16% <79.48%> (-0.06%) ⬇️
nucliadb_dataset 72.84% <ø> (ø)
nucliadb_models 69.70% <ø> (ø)
nucliadb_sdk 82.27% <ø> (ø)
nucliadb_telemetry 85.70% <ø> (ø)
nucliadb_utils 80.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread nucliadb/src/nucliadb/common/datamanagers/conversations.py Outdated
jotare
jotare previously approved these changes Jun 22, 2026
@lferran lferran merged commit 5e9a11b into main Jun 22, 2026
67 of 68 checks passed
@lferran lferran deleted the more-datamanagers-use branch June 22, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants