[EPIC] v0.7.x#657
Draft
derekpierre wants to merge 340 commits intomainfrom
Draft
Conversation
✅ Deploy Preview for taco-demo canceled.
|
✅ Deploy Preview for taco-nft-demo canceled.
|
derekpierre
force-pushed
the
epic-v0.7.x
branch
from
a69f20b to
884ffea
Compare
- Remove returnAggregated options from test calls - Update function calls to match new signUserOp signature - Remove unused options variable from test
- Remove returnAggregated option from signUserOp call in integration test
- Change aggregation logic from length > 0 to length >= threshold - Ensures aggregated signature only provided with sufficient signatures
- Fix existing test expectation for insufficient signatures case - Add new test to verify no aggregation when threshold not met - Ensure test coverage for both threshold met and unmet scenarios
…ecursive abi validation.
Move operator test from time.test.ts to return-value-test.test.ts.
…est should be specified). Improve human abi call signature validation check (wondering if there is a library out there that already does this) - there is one in python.
… of abi call signatures.
…s, and parameter and tuple indices. Add corresponding tests.
…ition objects to anyConditionSchema and to ConditionFactory resolution.
- Remove throw for mismatched message hashes - Include signature processing errors in result errors instead - Add try-catch for signature decoding failures - Continue processing other signatures when one fails - Let caller decide how to handle errors based on SignResult
- Change mismatched hash test to expect error in result instead of thrown - Verify result contains partial signatures and error details - Test that processing continues with valid signatures despite errors
- Add SigningOptions parameter with optimistic flag - Extract signature decoding logic to eliminate duplication - Optimistic mode: skip hash validation, use all signatures - Non-optimistic mode: validate hashes, only aggregate when threshold+ nodes agree - All signatures included in signingResults regardless of mode - Add comprehensive test coverage for new optimistic signing logic - Update existing test expectations for new signing behavior
…ed entry that never needs to be provided by the user/application. It is never included in the list of requested parameters, nor can it be added by the user/application. Ensure that the signing object context variable string itself can't be reused as a custom context variable.
…s. It is both a reserved context param and an automatically injected param.
…pdate made in `nucypher`.
Run pnpm fix.
…dices Idiomatic TypeScript prefers undefined over null for absent values. Addresses PR review feedback.
Don't include node v25 which has a change where node's built-in localStorage can interfere with the browser-like one.
The existing schema-docs-generation script produces a human-readable
markdown reference for condition schemas. This adds a sibling output
that emits a standard JSON Schema document for the full
ConditionExpression envelope ({version, condition}).
Editors that understand $schema (VS Code, JetBrains, Cursor) and LLMs
both consume this format directly, giving inline validation,
autocomplete, and structured output for any conditions.json file
without depending on @nucypher/taco at runtime.
The lazy union root (anyConditionSchema) is wrapped in the
ConditionExpression shape so the schema validates the same shape that
ConditionExpression.fromObj parses.
BigInt bounds (uint256 ranges) are stripped during serialization
because standard JSON Schema requires numeric bounds; the integer
type constraint still applies.
The markdown output also picks up an unrelated description-text
refresh from regenerating against the current schemas.
7 tasks
…ludes AA v0.7 support.
… parameter Update test.
Update test to use new type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: