Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #945 by correcting the logic in DelegateUnnecessaryAnalyzer to properly handle constraint expressions with multiple parts. The fix consolidates the constraint validation logic to avoid false positives when delayed constraints or throws constraints are present anywhere in the expression chain.
Key changes:
- Refactored constraint checking logic from a loop to a single conditional check
- Added test coverage for multi-part constraint expressions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/nunit.analyzers/DelegateUnnecessary/DelegateUnnecessaryAnalyzer.cs | Refactored constraint validation to check all parts upfront and return early if any delayed constraint exists |
| src/nunit.analyzers.tests/DelegateUnnecessary/DelegateUnnecessaryAnalyzerTests.cs | Added test cases for multi-part constraint expressions with Throws, Or, and After clauses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/nunit.analyzers.tests/DelegateUnnecessary/DelegateUnnecessaryAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
manfred-brands
force-pushed
the
Issue945_UnnecessaryDelelegatFix
branch
from
86fc926 to
ede254c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #945