fix: route admin dashboard + temporal ui through the app proxy#926
Merged
Conversation
Nuon Preview — main-testStatus: ⏳ In Progress ⏳ Parsing config... Nuon • |
Nuon Preview — main-testStatus: ⏳ In Progress ⏳ Parsing config... Nuon • |
Nuon Preview — main-testStatus: ✅ Complete Config Changes —
|
| Section | Added | Changed | Removed |
|---|---|---|---|
| Components | 0 | 1 | 0 |
Components (1)
- ~
component.ctl_api— : modified
Nuon • arnwdghmqxyztxcu9oj0hq48xp • Updated: Jul 20, 2026 5:52 AM UTC
The admin dashboard renders "View in Temporal" links from TEMPORAL_UI_URL as raw browser hrefs. On BYOC this pointed at cluster-internal addresses (GCP: temporal-ui.temporal.svc.cluster.local:8080; AWS: the internal domain), which are unreachable from a browser. Point TEMPORAL_UI_URL at the dashboard-ui reverse proxy (https://app.<root_domain>/admin/temporal) for both clouds. That path is same-origin with the admin dashboard, sits behind nuon auth, and dials the in-cluster temporal-web service server-side. Also wire dashboard_admin.alb.enabled on GCP (from admin_dashboard_alb_enabled) so that, with the alb disabled, the admin dashboard is served only via the app proxy at app.<root_domain>/admin/dashboard, matching AWS. Requires the companion nuonco/charts gate on the GCP ingress.
im-Amitto
force-pushed
the
am/admin-dashboard-app-proxy
branch
from
July 20, 2026 05:47
4edda00 to
5513d12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two BYOC
ctl-apiconfig fixes so the admin dashboard and its Temporal links are served through the dashboard-ui app proxy (app.<root_domain>), same-origin and behind nuon auth:TEMPORAL_UI_URL(GCP + AWS) →https://app.<root_domain>/admin/temporal.dashboard_admin.alb.enabledwiring (fromadmin_dashboard_alb_enabled).Why
The dashboard-ui server already reverse-proxies
/admin/dashboard/*(→ctl-api-dashboard-admin) and/admin/temporal/*(→ in-clustertemporal-web), both gated to@nuon.cousers. The BYOC configs were defeating it:${TEMPORAL_UI_URL}/namespaces/.... On GCP this washttp://temporal-ui.temporal.svc.cluster.local:8080(cluster-internal, unreachable from a browser); AWS pointed at the internal domain. Now both point at the app proxy path (matches mono's ownvalues.{prod,stage}.tmpl).dashboard_admin.alb.enabledlets the companion charts gate honor it, soalb=falseserves the dashboard only viaapp.<root_domain>/admin/dashboard.Depends on / related
dashboard_admin.alb.enabled). The GCPctl_apicomponent pins charts tobranch = main.admin_dashboard_alb_enabledtofalse.Notes
TEMPORAL_UI_URL(validate:"required"in ctl-api) stays non-empty. The dashboard-uiNUON_TEMPORAL_UI_URLupstream (temporal-web.temporal.svc.cluster.local:8080) is unchanged and correct.