[Natalie Tan] Duke Increments by nattanyz · Pull Request #344 · nus-cs2103-AY1920S1/duke

nattanyz · 2019-09-02T01:13:45Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

gary-lgy

Hi Natalie!
Basic functionalities are implemented. Comments are helpful for understanding the code.
Please refer to the individual comments for the specifics.
Don't forget to finish the leftover increments in time ;)

gary-lgy · 2019-09-04T09:42:10Z

@@ -1,10 +1,10 @@
+import java.util.Scanner;


Unused import :)

gary-lgy · 2019-09-04T09:45:55Z

+public class DukeBot {
+    private Scanner in;
+    private TaskList taskList = new TaskList();
+    private static final String welcomeMessage = "What can I do for you?";


From the coding standard:

Constant names must be all uppercase using underscore to separate words.

gary-lgy · 2019-09-04T09:47:44Z

+     * Starts DukeBot and prints welcome message.
+     */
+
+    public void initialise() {


These code should be in the constructor and run can be a public method that can be called separately IMO.

gary-lgy · 2019-09-04T09:48:08Z

+     */
+
+    public void initialise() {
+        String logo = " ____        _        \n"


Maybe this should be a constant too.

gary-lgy · 2019-09-04T09:49:56Z

+            input = in.nextLine();
+            if (input.equals("bye")) {
+                // if "bye", terminate
+                // todo: is there a way to combine this into processInput()?


Maybe you can make processInput return a boolean to indicate whether the command is "bye"

gary-lgy · 2019-09-04T10:10:18Z

+     *
+     * @param input input string given by user.
+     */
+    public void processInput(String input) throws InputMismatchException {


Instead of having almost all the app logic here, maybe it would help to define a Command class and a few subclasses like AddCommand, DoneCommand, etc. It would make the code more maintainable.

gary-lgy · 2019-09-04T10:12:42Z

+
+    public void printList() {
+        int i = 1;
+        for (Iterator<Task> iterator = this.tasks.iterator(); iterator.hasNext(); i++) {


I don't think the iterator here is necessary :)

gary-lgy · 2019-09-04T10:13:46Z

+        tasks.add(newTask);
+        System.out.println("Okay! I've added: " + description
+                + ". Use list to see all your tasks!");
+        // todo: description has trailing space due to using /at or /by as delimiter. how?


Use strip(), stripLeading(), stripTrailing(), whichever that suits your need :)

gary-lgy · 2019-09-04T10:19:18Z

+        TODO
+    }
+
+    public void addToList(TaskType taskType, String description, String deadline)


Maybe make this method take in a Task and construct the Task at the call site. This reduces duplicate code.

gary-lgy · 2019-09-04T10:20:18Z

+            }
+            break;
+        case "event":
+            inputReader.useDelimiter("/at");


This is pretty neat :)

SamYJ2606 · 2019-09-05T14:17:43Z

@@ -1,10 +1,10 @@
+import java.util.Scanner;


…to implement A-MoreOOP

…mentation(s) of execute() from previous version. currently unable to run: encountered "could not find or load main class Duke" error :(

…t Level-9 (find), fix String comparison bug

…his.tasks" with "tasks" in TaskList.java

…ddToList method and replace with calls to newTask() and add()

…geBox to represent different types of message boxes. change Gui class to use these subclasses.

Branch-Level-10

…-Level-10

…GuiDuke, build Jar file

Branch level 10

* 'master' of https://github.com/nattanyz/duke: (22 commits) remove redundant print statements in Task class, change filePath for GuiDuke, build Jar file remove System.out.println statements. add SaveCommand add showUserInput() method to Gui class add DukeMessageBox, ExceptionMessageBox, TaskMessageBox and UserMessageBox to represent different types of message boxes. change Gui class to use these subclasses. add Storage param back to execute() method in all Commands, add storage.save() when ExitCommand() is issued use ui.showMessage() in Storage class, add try/catch blocks to debug, manage to get partially working GUI (yay!) partially implement GUI using messageBoxQueue. changed font family and size. add DropShadow to MessageBox. complete refactoring from previous commit, add GREY colour scheme fix VBox width issue, complete refactoring of dialogBox to messageBox refactor: rename DialogBox to MessageBox.add ColourScheme enum to take care of customisable colour schemes. configure getUserDialog and getDukeDialog to use background and text colour create CliDuke and GuiDuke classes to implement Duke interface, set default invocation of Duke from CLI to use CliDuke and GUI to use GuiDuke continue refactoring in earlier commit replace Ui class with Ui interface and Cli and Gui implementations, attempt to do the same for Duke refactor: organise methods in Duke class fix scrolling and resizing behaviour of MainWindow, add some JavaDoc refactor: move GUI-related classes to duke.gui, add title and application icon rectify MainWindow fit wrap TextField and Button in HBox change images to png (but still cannot get them to appear) manage to compile and run, opens GUI window ...

…adme

Branch tests and assertions

…-Tests-and-Assertions * 'master' of https://github.com/nattanyz/duke: Set theme jekyll-theme-cayman

j-lum and others added 13 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S1#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

complete Level-1

2327b2a

add to process method, create DukeBot and TaskList classes

791010a

encapsulate logic in DukeBot class, implement Level-2

070f7e5

add Task class, implement Level-3

d497040

add TaskType enum, welcomeMessage, and minor changes to comments

17493be

modify process() method (incomplete)

f84bf53

implement Level-4, Level-5 and A-Exceptions

6bb6adf

gary-lgy reviewed Sep 4, 2019

View reviewed changes

implement Level-6, add deleteTask() method to TaskList class

6a07612

SamYJ2606 reviewed Sep 5, 2019

View reviewed changes

Comment thread src/main/java/Duke.java Outdated

@@ -1,10 +1,10 @@

import java.util.Scanner;

Copy link
Copy Markdown

SamYJ2606 Sep 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

nattanyz added 6 commits September 5, 2019 22:31

Merge branch 'gradle'

b1e9465

merge branch 'gradle'

7e6ed3a

start to implement gson for Level-7

070a1e2

create Command, Parser, Storage, Ui classes and remove DukeBot class …

148f51b

…to implement A-MoreOOP

create and update classes for each type of Command with working imple…

54e6458

…mentation(s) of execute() from previous version. currently unable to run: encountered "could not find or load main class Duke" error :(

something's wrong :(

8eafe91

nus-se-pr-bot added tutor.cchj1995 tutorial.CS2103-F09 team.2 labels Sep 6, 2019

nattanyz added 5 commits September 8, 2019 18:53

remove no-longer-used processInput method in TaskList class, implemen…

06492d2

…t Level-9 (find), fix String comparison bug

place java files in packages

d89a23a

add DukeTest.java, modify build.gradle to support JUnit

94dcf1c

remove unnecessary iterators and replace unnecessary references to "t…

13c1f9b

…his.tasks" with "tasks" in TaskList.java

add newTask method to separate creating and adding of tasks, remove a…

72d92b2

…ddToList method and replace with calls to newTask() and add()

nattanyz added 30 commits September 30, 2019 16:50

add DukeMessageBox, ExceptionMessageBox, TaskMessageBox and UserMessa…

427b3d6

…geBox to represent different types of message boxes. change Gui class to use these subclasses.

add showUserInput() method to Gui class

ed3a65a

remove System.out.println statements. add SaveCommand

8505aa5

Merge pull request #7 from nattanyz/branch-Level-10

68257c5

Branch-Level-10

Merge branch 'master' of https://github.com/nattanyz/duke into branch…

aff5481

…-Level-10

remove redundant print statements in Task class, change filePath for …

95fc0ad

…GuiDuke, build Jar file

Merge pull request #8 from nattanyz/branch-Level-10

506bd56

Branch level 10

begin writing readme

a988fae

remove external readme file

a9e589d

resize images in readme

5720d80

edits to readme

52bf5a7

complete readme

9725820

add assertions, fix some UI messages, remove redundant spaces

cd2608c

change application mainClassName in build.gradle, resize images in re…

434af83

…adme

Set theme jekyll-theme-cayman

77f0894

move screenshots to docs/images folder, publish GitHub pages

e6bd017

add ui.png to docs

39f4004

refactor: rename Duke to Dose

6a0dbab

add HelpCommand

5d1b9ae

add TaskTest

f44e942

add UiMessageTest

cad088e

Merge pull request #9 from nattanyz/branch-Tests-and-Assertions

e960263

Branch tests and assertions

Merge branch 'master' of https://github.com/nattanyz/duke into branch…

a1c9980

…-Tests-and-Assertions * 'master' of https://github.com/nattanyz/duke: Set theme jekyll-theme-cayman

Merge branch 'branch-Tests-and-Assertions'

d57ad03

fix broken image in readme, update build.gradle to build new jar

9f14515

fix text wrap, new v1.3 jar

711cb9b

final fix for text wrap, redo v1.3 jar

7ea9ef2

temporarily remove ui.png to fix naming

538e85a

add renamed ui.png file

8f03955

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Natalie Tan] Duke Increments#344

[Natalie Tan] Duke Increments#344
nattanyz wants to merge 96 commits intonus-cs2103-AY1920S1:masterfrom
nattanyz:master

nattanyz commented Sep 2, 2019

Uh oh!

gary-lgy left a comment •

edited

Loading

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

gary-lgy Sep 4, 2019

Uh oh!

SamYJ2606 Sep 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nattanyz commented Sep 2, 2019

Uh oh!

gary-lgy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gary-lgy left a comment •

edited

Loading