[Arun Kumarr] Duke Increments by ArunBeCoding · Pull Request #353 · nus-cs2103-AY1920S1/duke

ArunBeCoding · 2019-09-02T13:06:34Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

This reverts commit d96e6b1.

This reverts commit e786e40.

yaaanch · 2019-09-05T14:27:23Z

It's really good that you've written javadocs comments! But in the style guide, they suggest that the javadoc comments should be capitalised and start with a singular verb. Also, @param doesn't need the "is" word. So for example,

constructor for child class
defines the midcommand, and calculates the formattedDate
@param command is the user input string
@throws DukeException in case date is not entered in the correct format

could be something like

Constructs a Deadline with a description of the deadline and the date of the deadline.
@param command The user input string.
@throws DukeException If date is not entered in the correct format.

It's good that you've split up the tasks into more OOP, like with the parser, ui, and storage. I think another way of splitting it up would be to move the interpretation of the commands into the parser, and just have the ui for the printing.

It's also possible to go into even more OOP, for example having different commands. Then your parser could pass command objects back to Duke, then Duke executes the command with the Ui, Storage, and TasksList.

For error handling, some error names could be more descriptive, like DukeException for date formatting.

Good job overall!

yyuanxin · 2019-09-06T11:50:47Z

Hi Arun! I like that you have included Javadoc comments for most of your methods and have separated your test cases into different classes for jUnit testing which makes it more organised! (something I should consider doing as well).

Some suggestions:

introduce command classes to handle the user input - making it more OOP
organise your code with packages.

Overall, I think you have done a good job!

WilliamRyank · 2019-09-12T05:21:23Z

+     * to print for "list" command
+     * @return string in the format required
+     */
+    public String printer(){


Need a space before the curly bracket.

SimNee · 2019-09-12T05:22:32Z

+        try {
+            int val = Integer.parseInt(splitWords[1]);
+            ui.deleteMessage(val-1, tasks);
+            //System.out.println("Noted. I've removed this task:"+ "\n" + tasks.taskPrint(val-1) +


Can delete the comments if it is not needed anymore :)

Yen-Peng · 2019-09-12T05:23:08Z

+     * to print for text file
+     * @return string in the format required
+     */
+    public String printToOutput(){


add a space between () and {

Yen-Peng · 2019-09-12T05:23:48Z

+     * @throws DukeException in case segments[3] is not in the proper date format
+     */
+    public static Task outputAsDeadline(String s) throws DukeException {
+        String[]segments = s.split("\\|");


add a space between [] and segments

Yen-Peng · 2019-09-12T05:25:19Z

+     * @throws Exception in case user inputs in an incorrect format
+     */
+    public static void createDeadline(String command, TaskList tasks, Storage storage) throws DukeException {
+        String[]splitWords = command.trim().split("\\s",2);


add space between [] and splitWords

SimNee · 2019-09-12T05:25:48Z

+
+        if (segments[1].equals(" 1 ")) {
+            newTask.taskDone();
+        } else {}


Should not have an empty else block :)

WilliamRyank · 2019-09-12T05:26:20Z

+     * @return a Task (Deadline) object
+     * @throws DukeException in case segments[3] is not in the proper date format
+     */
+    public static Task outputAsDeadline(String s) throws DukeException {


Maybe can use better argument name instead of s as it is not intuitive

Yen-Peng · 2019-09-12T05:26:55Z

+    /**
+     * marks when task is done
+     */
+    public void taskDone(){


line 97, 104 & 112: space between () & {
line 97 to 107: You may consider either using try-catch block and throw your exception inside the try block, or just if-else and throw your exception in else block.

WilliamRyank · 2019-09-12T05:30:56Z

+     * exception for incorrect date format
+     * @param message is dummy parameter
+     */
+    public DukeException(String message){


Space before curly bracket

WilliamRyank · 2019-09-12T05:33:37Z

+            String taskCommand = tasks.get(i).getCommand();
+            if (taskCommand.contains(wordToFind) ){
+                findResults.add(tasks.get(i));
+            }else{}


Consider removing empty else.

SimNee · 2019-09-12T05:34:10Z

+        String[]splitUpDate = command.split("/",2);
+
+        try {
+            SimpleDateFormat ft = new SimpleDateFormat("dd/MM/yyyy HHmm");


Could use more informative naming :) eg. dateformat

A-Assertions

A code quality

j-lum and others added 26 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Level 1

5c09abd

Level 2

e061d04

Level 3

b0be3da

Level 4

c9d5140

Level 5

848dad6

Level 6

ec29a11

Merge branch 'gradle'

3058715

Final

420ea4d

level 6-updated

d96e6b1

Revert "level 6-updated"

e786e40

This reverts commit d96e6b1.

level-6-updated

82fe496

level-7

35a7603

Revert "Revert "level 6-updated""

f6b0a7c

This reverts commit e786e40.

branch-level-8

e905f23

Merge branch 'branch-level-7'

473a192

Merge branch 'branch-level-8'

3f4683b

level 8-updated

b276a72

A-MoreOOP

65121f1

JUnit Testing

6d5eca4

A-JavaDocs

200a1e7

A-CodingStandard

8a14ee2

level-9

94c71b5

nus-se-pr-bot added tutor.junrong09 tutorial.CS2103T-T12 labels Sep 6, 2019

WilliamRyank reviewed Sep 12, 2019

View reviewed changes

SimNee reviewed Sep 12, 2019

View reviewed changes

Yen-Peng reviewed Sep 12, 2019

View reviewed changes

SimNee reviewed Sep 12, 2019

View reviewed changes

WilliamRyank reviewed Sep 12, 2019

View reviewed changes

Yen-Peng reviewed Sep 12, 2019

View reviewed changes

WilliamRyank reviewed Sep 12, 2019

View reviewed changes

SimNee reviewed Sep 12, 2019

View reviewed changes

ArunBeCoding and others added 19 commits September 14, 2019 07:52

JavaFX-Tutorial 4

bb06e49

small-changes

7323cfc

A-Assertions

ab4c91a

Merge pull request #5 from ArunBeCoding/A-Assertions

cd664f0

A-Assertions

checkstyle changes

bc8b008

streamlining execute

a43cb6e

Merge pull request #6 from ArunBeCoding/A-CodeQuality

6305f18

A code quality

ignore output text files

35fecc1

Merge branch 'master' of https://github.com/ArunBeCoding/duke

ce5a83e

A-Travis

d26f80f

travis

1f21ff1

D-Expenses

32611d5

screenshot

c9af099

cleaning up

ef3a55c

Set theme jekyll-theme-minimal

e54d297

readme file

3cea7d2

Merge branch 'master' of https://github.com/ArunBeCoding/duke

044e5a5

checkstyle changes

e01c61f

A-Release

24cf796

Conversation

ArunBeCoding commented Sep 2, 2019

Uh oh!

yaaanch commented Sep 5, 2019

Uh oh!

yyuanxin commented Sep 6, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yen-Peng Sep 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Yen-Peng Sep 12, 2019 •

edited

Loading