[Shirley] Duke Increments#447
Open
bitterg0d wants to merge 42 commits intonus-cs2103-AY1920S1:masterfrom
Open
Conversation
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
…support multiple task types
This reverts commit 3ff017e.
This reverts commit 3ff017e.
# Conflicts: # src/main/java/Deadline.java # src/main/java/Duke.java
tiuweehan
reviewed
Sep 11, 2019
le0tan
reviewed
Sep 11, 2019
tiuweehan
reviewed
Sep 11, 2019
|
|
||
| for (Task task: list) { | ||
| if (task instanceof Event) { | ||
| s = "E" + " | "+ task.getDone() + " | " + task.getDesc() + " | " + task.getAt(); |
There was a problem hiding this comment.
Rather than having multiple if else statements, you can create an abstract method on the Task class that converts the task to a suitable storage format.
jiayushe
reviewed
Sep 11, 2019
jiayushe
left a comment
jiayushe
left a comment
There was a problem hiding this comment.
Good effort. Some comments for your consideration.
elsakoh
reviewed
Sep 29, 2019
elsakoh
left a comment
elsakoh
left a comment
There was a problem hiding this comment.
i liked that you abstracted out the different commands regarding list, very neat and easy to read code, keep up the good work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.