[Goh Yijie Jonathan] ip by jgyj123 · Pull Request #499 · nus-cs2103-AY2223S1/ip

jgyj123 · 2022-08-28T19:50:45Z

Project Duke

Swift command line interface
good user experience
best robot out there 👍

Some of the core features include:

Keeping track of tasks using list
Marking them as complete
Storing of tasks

~~Completed task~~
Do homework
Submit the assignment (by 20 Aug 2022)

This is the best robot I have ever met
This robot was built by Jonathan

Here is some random code:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

1) Todos 2) Deadlines 3) Events

This reverts commit 92d3732.

This reverts commit 1e2205a.

This reverts commit 41fea6a.

malwaregarry · 2022-08-29T05:32:55Z

+     * @param s Command containing task message and time
+     * @param isCompleted whether the task is completed
+     */
+    public Deadline (String s , boolean isCompleted) {


Should this whitespace be removed?

malwaregarry · 2022-08-29T05:38:05Z

@@ -1,10 +1,51 @@
+/**
+ * Main java class to create a new Duke object


according to the module's coding standard, javadoc comments should end with a fullstop. This is different from git subject headers which states not to end with a fullstop.

malwaregarry · 2022-08-29T05:44:08Z

+        }
+        if (taskAdded) {
+            Task addedTask = tasks.get(tasks.getSize() - 1);
+            System.out.println("Got it. I've added this task: \n" + addedTask.toString() +


perhaps the + would be nicer at the start of the next line:

System.out.println("Got it. I've added this task: \n" + addedTask.toString() + "\nNow you have " + tasks.getSize() + " tasks in the list.");

malwaregarry · 2022-08-29T05:44:48Z

+public class Parser {
+    private Storage s;
+    private Ui ui;
+    private TaskList tasks;


perhaps a better variable would be taskList as tasks might imply a collection of task

malwaregarry · 2022-08-29T05:47:04Z

@@ -0,0 +1,34 @@
+/**
+ * Represents an Event that can be created by the user
+ */


perhaps it would be more readable just before the class

malwaregarry · 2022-08-29T05:50:34Z

+                if (taskType.equals("T")) {
+                    tasks.add(new Todo("todo " + taskMessage, isTaskCompleted));
+                }
+                else if (taskType.equals("E")) {


perhaps to you could start the else clause to the curly bracket to meet the coding standard?

if (condition) { statements; } else if (condition) { statements; } else { statements; }

malwaregarry · 2022-08-29T09:59:30Z

+    }
+
+    /**
+     * functional method to delete a task


I believe the first letter in each javadoc comment should be capitalised?

malwaregarry

LGTM not much issues. Your code is easy to read and I could only spot some minor coding standard violations.

There is a need to check that methods in TaskList and Storage class are being passed valid arguments Let's use assertions to implement these safety checks Using assertions will help to reduce bugs in the code and increase confidence in the correctness of the code

Parse method is too long and hard to read Let's refactor the parse method This will help to make the code more readable and scalable

Use Assert feature There is a need to check that methods in TaskList and Storage class are being passed valid arguments Let's use assertions to implement these safety checks Using assertions will help to reduce bugs in the code and increase confidence in the correctness of the code

* master: Use Assert feature

Improve code quality of code in parser class Parse method is too long and hard to read Let's refactor the parse method This will help to make the code more readable and scalable

damithc and others added 28 commits July 31, 2022 17:20

Add Gradle support

556af3f

Added command echoing (level -1)

debd796

Level 2. Add, List

5feb915

Add the ability to mark tasks as done.

d64bbe9

Add support for tracking three types of tasks:

9eec39d

1) Todos 2) Deadlines 3) Events

Add Automated Text UI Testing

d5676a5

Add Exception Handling

d26111e

Add support for deleting tasks from the list.

757d895

Add support for saving task in hard disk

09540fe

Add support for missing data folder

c58d886

Add date parsing functionality

f4e7424

Add parsing for dates

92d3732

Revert "Add parsing for dates"

1e2205a

This reverts commit 92d3732.

Revert "Revert "Add parsing for dates""

41fea6a

This reverts commit 1e2205a.

Revert "Revert "Revert "Add parsing for dates"""

541ace7

This reverts commit 41fea6a.

Add date parsing

b867d99

Resolve bugs after merging branches 7 and 8

f17a1bf

Use more OOP

4ea4b78

Add gradle support

482591f

Add test file skeleton

176cafe

Add JUnit tests

e3d9944

Update marking of finished tasks

85ad687

Add JavaDoc for classes and methods

4a90319

Follow coding standard

353532f

Enable users to find task by searching for keyword

cd59fe1

Merge branch 'A-JavaDoc'

213a3c1

Merge branch 'A-CodingStandard'

f580256

Merge branch 'Level-9'

3b4851d

malwaregarry reviewed Aug 29, 2022

View reviewed changes

jgyj123 and others added 14 commits August 29, 2022 23:57

Divide classes into packages

04e0e8c

Add GUI to Duke using JavaFX

8b74845

Merge branch 'branch-Level-10'

5ea0c5e

update entry point of application

d501d21

Use Assert feature

33a1260

There is a need to check that methods in TaskList and Storage class are being passed valid arguments Let's use assertions to implement these safety checks Using assertions will help to reduce bugs in the code and increase confidence in the correctness of the code

Improve code quality of code in parser class

3e398db

Parse method is too long and hard to read Let's refactor the parse method This will help to make the code more readable and scalable

Merge branch 'master' into A-CodeQuality

ee48c2c

* master: Use Assert feature

Merge pull request #2 from jgyj123/A-CodeQuality

2318de5

Improve code quality of code in parser class Parse method is too long and hard to read Let's refactor the parse method This will help to make the code more readable and scalable

Allow users to view deadlines and events on a specified date

319c864

Allow users to indicate time of event and deadline

62848e1

Add user guide

dc171d6

Add line spacing to readme

8b23f7d

Add more line spacing to readme

851ccae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Goh Yijie Jonathan] ip - #499

[Goh Yijie Jonathan] ip#499
jgyj123 wants to merge 42 commits into
nus-cs2103-AY2223S1:masterfrom
jgyj123:master

jgyj123 commented Aug 28, 2022 •

edited

Loading

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry Aug 29, 2022 •

edited

Loading

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry Aug 29, 2022

Uh oh!

malwaregarry left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1,10 +1,51 @@
		/**
		* Main java class to create a new Duke object

Uh oh!

Conversation

jgyj123 commented Aug 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project Duke

Some of the core features include:

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

malwaregarry left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jgyj123 commented Aug 28, 2022 •

edited

Loading

malwaregarry Aug 29, 2022 •

edited

Loading