[Liu Han] ip by SweetPotato0213 · Pull Request #500 · nus-cs2103-AY2223S1/ip

SweetPotato0213 · 2022-08-29T02:57:24Z

Duke Helper

“Your mind is for having ideas, not holding them.” – David Allen Quoted from here

Introduction

Duke is an interactive personal chat robot designed for people tired of remembering all the tasks they've done or they're going to do. It's

text-based
easy to use
retentive enough to remember all the tasks you've ever mentioned
free!

Steps to use

Download it from here
Go to the directory and double-click Duke
Input your tasks (including to-do, event, and deadline)
Let it manage your tasks for you 😆

Features

Managing events
Managing to-do's
Managing dealines
Reminders (coming soon)

Addition

If you are a Java programmer, you can also use it to practice Java. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

Greet, Echo, Exit

sarrrdin

Looks good. 👍
Some cosmetic changes are requested to follow coding standards.
LGTM.

sarrrdin · 2022-08-29T05:18:52Z

+        bye,
+        list,
+        mark,
+        unmark,
+        todo,
+        delete


Enum names should be written in PascalCase or all uppercase?

BYE, LIST, ...

sarrrdin · 2022-08-29T05:21:59Z

+    }
+
    public static void main(String[] args) {
        String logo = " ____        _        \n"


I'm thinking that maybe variable logo can be set as final?

sarrrdin · 2022-08-29T05:23:07Z


 # compile the code into the bin folder, terminates if error occurred
-if ! javac -cp ../src/main/java -Xlint:none -d ../bin ../src/main/java/*.java
+if ! javac -cp ../src/main/java -Xlint:none -d ../bin ../src/main/java/Duke.java


I like how you changed the accessibility where it is more specific 😄

sarrrdin · 2022-08-29T05:24:49Z

                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);
+        String hello = "____________________________________________________________\n" +


I think can leave an empty space here?

sarrrdin · 2022-08-29T05:25:45Z

@@ -1,10 +1,53 @@
+import java.util.*;


Import of classes should be listed explicitly?

sarrrdin · 2022-08-29T05:26:36Z

+                "     Here are the tasks in your list:";
+
+        System.out.println(strlst);
+


I think can remove a blank line here 😃

Update all the codes to follow coding standards

correct the functions for level 2

Correct the functions and separate Task class from Duke class file

nmtuan2001 · 2022-08-30T07:53:46Z

+                "    ____________________________________________________________\n";
+        System.out.println(hello);
+
+        List<Task> list = new ArrayList<Task>();


Maybe you can change this variable name to tasks or something like that to make it clearer?

nmtuan2001 · 2022-08-30T07:54:43Z

+
+        System.out.println(strlst);
+
+        String todolist = "____________________________________________________________\n" +


Should this be todoList?

Qiaoran-M

LGTM!

Qiaoran-M · 2022-09-03T06:30:49Z

+                int number = sc.nextInt();
+                Task task = list.get(number - 1);
+                task.markAsDone();
+                System.out.println("    ____________________________________________________________\n" +


You may consider placing line break before operator +

Qiaoran-M · 2022-09-03T06:37:25Z

+
+
+
+        String strlst = "____________________________________________________________\n" +


Maybe you can change this variable to stringList or something like that to make it clearer?

Qiaoran-M · 2022-09-03T06:38:16Z

+
 public class Duke {
+
+    enum Ability {


Good use of enums for different commands!

tensaida

You've made good progress in your iP. All the best for future weeks

tensaida · 2022-09-04T16:23:06Z

+                int number = sc.nextInt();
+                Task task = list.get(number - 1);
+                task.markAsDone();
+                System.out.println("    ____________________________________________________________\n" +


Also consider storing the separator as a constant

tensaida · 2022-09-04T16:25:04Z

+        String hello = "    ____________________________________________________________\n" +
+                "     Hello! I'm Duke\n" +
+                "     What can I do for you?\n" +
+                "    ____________________________________________________________\n";


Good minimalist design

tensaida · 2022-09-04T16:25:47Z

+        String input = sc.next();
+
+        while (!input.equals("bye")) {
+            if (input.equals("list")) {


Consider using switch case instead of if-else

Correct and supplement

Update and correct the codes

Add delete function

Save the tasks in the hard disk automatically whenever the task list changes.

Teach Duke how to understand dates and times. Store deadline dates as a java.time.LocalDate objects. Accept dates in yyyy-mm-dd format (e.g., 2019-10-15) and print in a different format MMM dd yyyy e.g., (Oct 15 2019).

Do it in a new branch

Update code in a new branch

it's for merge trial

Added Storage, Parser, TaskList classes

Package all classes into duke

Use Gradle to automate some of the build tasks of the project. Now I can run Duke.main() using Gradle but cannot run it in the terminal (If I do java Duke.java it will report 9 errors saying cannot find symbols and compilation failed. I don't know why.).

create a folder (test/java/duke) to place all the test classes, use Assertions to compare the expected and actual outcomes

Package the app as an executable JAR file so that it can be distributed easily.

Add JavaDoc comments to the code. Add header comments to all non-private classes/methods.

Tweak the code to comply with a coding standard.

Give users a way to find a task by searching for a keyword.

Place line break before operators.

Modify parser method (return value from void to String)

Make some cosmetic changes to the codes according to the iP code quality feedback from teaching group

Add assert statement in printList method in Parser class

Improve the Javadoc statement for getStatus method

Use Assertions

damithc and others added 9 commits July 31, 2022 17:20

Add Gradle support

556af3f

Level 1

9676077

Greet, Echo, Exit

Level 2. Add, List

0d9ef52

Level 3. Mark as Done

5da01cb

Level 4. ToDos, Events, Deadlines

0de5e80

A-TextUiTesting: Automated Text UI Testing

3eed790

Level 5. Handle Errors

dac7f8e

Level 6. Delete

880e4c0

A-Enums: Use Enums

2fe064a

sarrrdin reviewed Aug 29, 2022

View reviewed changes

SweetPotato0213 added 3 commits August 29, 2022 16:15

Cosmetic changes to follow coding standards

a553d00

Update all the codes to follow coding standards

Level 2(v2)

f5659ce

correct the functions for level 2

Level 3(v2)

27413b8

Correct the functions and separate Task class from Duke class file

nmtuan2001 reviewed Aug 30, 2022

View reviewed changes

Qiaoran-M reviewed Sep 3, 2022

View reviewed changes

tensaida reviewed Sep 4, 2022

View reviewed changes

SweetPotato0213 added 14 commits September 5, 2022 16:25

Level 4(v2)

ab182d3

Correct and supplement

Test using the I/O redirection technique

a226e93

Level 5(v2)

dbe31f4

Update and correct the codes

Level 6(v2)

ab2bbb2

Add delete function

Level 7.Save

d224115

Save the tasks in the hard disk automatically whenever the task list changes.

Level 8. Dates and Times

ece43a0

Teach Duke how to understand dates and times. Store deadline dates as a java.time.LocalDate objects. Accept dates in yyyy-mm-dd format (e.g., 2019-10-15) and print in a different format MMM dd yyyy e.g., (Oct 15 2019).

Level 7. Save

eb63281

Do it in a new branch

Level 8. Date time

0e48f38

Update code in a new branch

Merge branch 'branch-Level-8'

e98b02e

Level 7(v2)

474467d

it's for merge trial

Merge branch 'branch-Level-7'

3f2cd52

Use More OOP

1f03af6

Added Storage, Parser, TaskList classes

Organize classes into a package

dd62132

Package all classes into duke

Merge branch 'add-gradle-support'

82c1254

SweetPotato0213 and others added 23 commits September 7, 2022 00:24

Use Gradle

fce0fb3

Use Gradle to automate some of the build tasks of the project. Now I can run Duke.main() using Gradle but cannot run it in the terminal (If I do java Duke.java it will report 9 errors saying cannot find symbols and compilation failed. I don't know why.).

Add JUnit Tests

733de7f

create a folder (test/java/duke) to place all the test classes, use Assertions to compare the expected and actual outcomes

Create a JAR file

aea7a3a

Package the app as an executable JAR file so that it can be distributed easily.

Add JavaDoc Comments

75e8974

Add JavaDoc comments to the code. Add header comments to all non-private classes/methods.

Follow the coding standard

f96b9c0

Tweak the code to comply with a coding standard.

Implement Find function

0948713

Give users a way to find a task by searching for a keyword.

Merge branch 'branch-A-CodingStandard'

66c9edc

Merge branch 'branch-Level-9'

8a3b775

Cosmetic changes following coding standard

c8a71d1

Place line break before operators.

javafx test

4c5a763

Added Main.java and fxml files

82f3c2b

Create MainWindow.java

f22bafd

Added GUI

57cac3f

Modify parser method (return value from void to String)

Improve Code Quality

64a62a0

Make some cosmetic changes to the codes according to the iP code quality feedback from teaching group

Use Assertions

3493580

Add assert statement in printList method in Parser class

Improve the Javadoc statement for getStatus method

6a2a08d

Merge pull request #2 from SweetPotato0213/branch-A-CodeQuality

068277a

Improve the Javadoc statement for getStatus method

Merge pull request #3 from SweetPotato0213/branch-A-Assertions

16a3594

Use Assertions

Add an extension Update

719d544

User Guide

20602c7

Attempt to get the GUI work

4faf015

CLI correction

271d87c

CLI update

d8c698b

		" Here are the tasks in your list:";

		System.out.println(strlst);


		System.out.println(strlst);

		String todolist = "____________________________________________________________\n" +




		String strlst = "____________________________________________________________\n" +

Uh oh!

Conversation

SweetPotato0213 commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Duke Helper

Introduction

Steps to use

Features

Addition

Uh oh!

sarrrdin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Qiaoran-M left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tensaida left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SweetPotato0213 commented Aug 29, 2022 •

edited

Loading