[Lim Zhan Feng] iP by LolfoollorS · Pull Request #514 · nus-cs2103-AY2223S1/ip

LolfoollorS · 2022-08-31T12:32:26Z

Clevernotbot

“Humans Need Not Apply.” – CPG Grey (source)

Trying to relive the old days? Well look no further. Try Clevernotbot! It's

has a task tracking capability
text-based
easy to learn

Did I also mention that it is FREE OF CHARGE? All you need to do now is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

Features:

Managing tasks
Managing deadlines
~~Reminders~~ (pending)
If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

# Conflicts: # src/main/java/Deadline.java

Update Deadline.java

Update all functions to command. Update Handler to Parser Update UITextbox to UI

This reverts commit 189448e.

# Conflicts: # src/main/java/clevernotbot/AddDeadLineCommand.java # src/main/java/clevernotbot/AddEventCommand.java # src/main/java/clevernotbot/AddToDoCommand.java # src/main/java/clevernotbot/ByeCommand.java # src/main/java/clevernotbot/CleverNotBotException.java # src/main/java/clevernotbot/Deadline.java # src/main/java/clevernotbot/DefaultCommand.java # src/main/java/clevernotbot/DeleteCommand.java # src/main/java/clevernotbot/Event.java # src/main/java/clevernotbot/GreetCommand.java # src/main/java/clevernotbot/ListCommand.java # src/main/java/clevernotbot/MarkCommand.java # src/main/java/clevernotbot/Parser.java # src/main/java/clevernotbot/Storage.java # src/main/java/clevernotbot/Task.java # src/main/java/clevernotbot/TaskList.java # src/main/java/clevernotbot/ToDo.java # src/main/java/clevernotbot/UI.java # src/main/java/clevernotbot/UnmarkCommand.java

# Conflicts: # src/main/java/clevernotbot/TaskList.java

Update UnmarkCommand.java

ShawnChew

Overall I think you followed the Java Coding Standard closely. 👍

ShawnChew · 2022-09-02T17:53:12Z

+ */
+public abstract class Command {
+    private String commandName;
+    private boolean exit;


Perhaps you could rename the variable to make it sound like a boolean.

ShawnChew · 2022-09-02T17:59:00Z

+     * @return A toggled version of deadline. (Completed = true -> Completed = false)
+     */
+    @Override
+    public Task toggleCompleted() {


Name of method sounds a little misleading, perhaps you could name it as toggleCompletionStatus.

ShawnChew · 2022-09-02T18:03:50Z

+     * @param tasks   The task list used to store all tasks.
+     * @param textBox UI for the textbox.
+     * @param storage The data where it is stored.


I like that you aligned the descriptions for the params to make it look neater.

ShawnChew · 2022-09-02T18:06:02Z

+     * Toggles the completion of event task.
+     *
+     * @return A toggled version of event. (Completed = true -> Completed = false)


Perhaps you could write the content in the parenthesis, in the second sentence of the description instead of on the @return line.

ShawnChew · 2022-09-02T18:08:11Z

+        System.out.println(file.getAbsolutePath());
+        System.out.println(String.join(",",content));
+         */
+        //"1".equals(content[1]) is to convert it to boolean


I like how you commented on what the code is doing.

ShawnChew · 2022-09-02T18:11:58Z

+    /**
+     * Toggles the completion of todo task.
+     *
+     * @return A toggled version of todo. (Completed = true -> Completed = false)
+     */


You can omit header comments for overriding methods (provided the parent method's Javadoc applies exactly as is to the overridden method).

PokezardVGC · 2022-09-04T11:24:10Z

+     * Constructor for the AddEventCommand.
+     *
+     * @param commandName Description of Command.
+     * @param exit        Checking if program intends to exit.


Good use of alignment to keep description on one side and parameters on the other

PokezardVGC · 2022-09-04T11:25:08Z

+ * a task with a time range e.g., <code>Aug 6th 2-4pm</code>
+ */
+public class Event extends Task {
+    private String at;


possible to make this private final?

PokezardVGC · 2022-09-04T11:25:53Z

+ */
+public class TaskList {
+    private ArrayList<Task> tasks;
+    private int size;


likewise, possible to make it private final? Maybe create a new TaskList object with each function call

…rk a` `delete a`

Add HelpCommand.java Adhere to Coding Standards Change to assist people that requires help. Add HelpCommand if user needs help.

Update Sprite for bot.

damithc and others added 22 commits July 31, 2022 17:20

Add Gradle support

556af3f

Added level 1- 6, A-Collections

dc082c3

Remove Text block literal (Not supported in JDK11)

cd6befb

Add Level 7

ae43f2c

Add Level-8

62afe57

Merge branch 'branch-Level-7'

3e2dd5b

Merge branch 'branch-Level-8'

5e31a06

# Conflicts: # src/main/java/Deadline.java

Update AddFunctionDeadLine.java

3c67594

Update Deadline.java

Merge remote-tracking branch 'origin/add-gradle-support'

d98bebb

Add A-MoreOOP

69f112c

Update all functions to command. Update Handler to Parser Update UITextbox to UI

Add packages to all the relevant classes

0677f09

Add A-JUnit: ParserTest, TaskListTest, ToDoTest

3b3702f

Add A-Jar

de8b34e

Add JavaDocs for all classes except CleverNotBot.java .

189448e

Revert "Add JavaDocs for all classes except CleverNotBot.java ."

ecfcad8

This reverts commit 189448e.

Add JavaDocs to all non main classes.

648ed7e

Add Coding Standard to code.

c418254

Add Level 9

68f3e8d

Merge branch 'branch-A-JavaDoc'

2d9aa6d

Merge branch 'branch-Level-9'

847dd6c

# Conflicts: # src/main/java/clevernotbot/TaskList.java

Update MarkCommand.java

0ea15bf

Update UnmarkCommand.java

ShawnChew reviewed Sep 2, 2022

View reviewed changes

PokezardVGC reviewed Sep 4, 2022

View reviewed changes

LolfoollorS added 6 commits September 4, 2022 19:46

Add catch for non numeric number after command such as mark a `unma…

48d0376

…rk a` `delete a`

Refactored Storage.java

2beda42

Add Level-10 Gui

0e7cc9f

no message

2836fea

Add C-Undo for undo personal

e09f5f9

Add A-UserGuide

3b740c3

LolfoollorS added 9 commits September 18, 2022 22:01

Add HelpWindow.fxml

6de5831

Add HelpCommand.java Adhere to Coding Standards Change to assist people that requires help. Add HelpCommand if user needs help.

Add UI for Docs

6a9948e

Change mainclassname in build.gradle

8bd2385

Modify README.md

b5898aa

Renam UI to Ui.png

b66666c

Improve dialog box

e974db1

Update CSS and FXML files

9928cd0

Force Java 11 Compile.

c2a27ac

Update Sprite for bot.

Update app scene and Ui.png

2a4775f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Lim Zhan Feng] iP - #514

[Lim Zhan Feng] iP#514
LolfoollorS wants to merge 37 commits into
nus-cs2103-AY2223S1:masterfrom
LolfoollorS:master

LolfoollorS commented Aug 31, 2022 •

edited

Loading

Uh oh!

ShawnChew left a comment

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

ShawnChew Sep 2, 2022

Uh oh!

PokezardVGC Sep 4, 2022

Uh oh!

PokezardVGC Sep 4, 2022

Uh oh!

PokezardVGC Sep 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

LolfoollorS commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Clevernotbot

Uh oh!

ShawnChew left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LolfoollorS commented Aug 31, 2022 •

edited

Loading