[Singh Abdullah Alexander] iP by alexandermula · Pull Request #519 · nus-cs2103-AY2223S1/ip

alexandermula · 2022-09-01T14:32:20Z

Chacha

“If you fail to plan, you are planning to fail.” – Benjamin Franklin (view quote)

Chacha helps you plan an track upcoming tasks. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😊

And it is FREE!

Features:

If you are familiar with Java, you can use it to practice too. Here's the main method:

public class Launcher {
    public static void main(String[] args) {
        Application.launch(Main.class, args);
    }
}

Kennethsim2000

Ultimately, good job on the code!

Kennethsim2000 · 2022-09-02T12:03:17Z

+public class Deadline extends Task {
+    private String description;
+    private LocalDate date;
+    private boolean isDone;


Good naming of booleans:)

Kennethsim2000 · 2022-09-02T12:05:08Z

+    public static void main(String[] args) {
+        System.out.println("Hello! I'm Chacha\n" + "What can I do for you?");
+        Scanner input = new Scanner(System.in);
+        String s = input.nextLine();


Maybe can name s differently? To a clearer variable

Kennethsim2000 · 2022-09-02T12:05:53Z

+        System.out.println("Hello! I'm Chacha\n" + "What can I do for you?");
+        Scanner input = new Scanner(System.in);
+        String s = input.nextLine();
+        ArrayList<Task> taskList = new ArrayList<Task>();


Good that the variable names are in camel case

add storage logic fix parser

…-support

hoang227 · 2022-09-04T10:28:52Z

@@ -0,0 +1,102 @@
+package chacha;
+
+import java.io.BufferedWriter;


Maybe you should consider adding spaces in between import statements from different packages to improve readability.

hoang227 · 2022-09-04T10:32:58Z

+            dateTime = LocalDateTime.parse(date, formatter);
+        }  
+        Task task = new Task();
+        switch (type) {


The indentation for the switch statement does not follow the recommended standard. 'switch' and 'case' should have the same indentation.

Gavzzz · 2022-09-04T10:31:01Z

+            //load task objects into array
+            System.out.println(s.nextLine());
+        }
+    }


Overall code looks clean and should have no problem finishing up the ip

Gavzzz · 2022-09-04T10:40:17Z

        Scanner input = new Scanner(System.in);
        String s = input.nextLine();
-        ArrayList<String> list = new ArrayList<String>();
+        ArrayList<Task> taskList = new ArrayList<Task>();


Can consider making taskList a private static final field in the class

Gavzzz · 2022-09-04T10:41:19Z

+                        t.getDescription()); 		
 	            }   
+
+            } else if (s.contains("unmark")) {


Can consider using s.startsWith function to check if the task type is indeed the first input

# Conflicts: # src/main/java/chacha/TaskList.java # src/main/java/chacha/commands/ExitCommand.java # src/main/java/chacha/commands/ListCommand.java # src/main/java/chacha/tasks/Deadline.java # src/main/java/chacha/tasks/Todo.java

# Conflicts: # src/main/java/chacha/Ui.java

add assert statements

fix code quality

Sort command is null safe to handle todo tasks. A sort is necessary for users to sort tasks chronologically. Using a custom comparator class for tasks is preferable because other sorting parameters such as description can be added later. Refer to this S/O discussion on dealing with multiple comparators as a chain https://codereview.stackexchange.com/questions/229497/handle-null-in-comparator-class

Add sort command

Find command finds returns all tasks with any of the keywords. A find command which accepts multiple arguments is more user-friendly for users who wish to search for multiple types of tasks at once.

Find command: add varargs to pass multiple keywords

Enums control the switch statement in parser. A separate enum class will allow for ease of future additions of commands.

Edit the fxml view files to update styling for GUI. Styling the GUI makes the chatbot more user friendly.

Modify UI responses and error responses to create personality for Chacha. Adding a personality improves user-friendliness of Chacha's interactions with users.

Github page as documentation for user. By adding a website, users can easily refer to usage of the product.

-Fix arrowhead in Chacha getResponse

-Fix Parser SLAP

damithc and others added 11 commits July 31, 2022 17:20

Add Gradle support

556af3f

Completed Level-1

df365b5

added list

1346cd5

Added mark as done

35f557b

ToDos, Events and Deadlines

1427298

Text testing

924806e

error handling

7a099dd

Implemented delete

23228eb

Added file read function (to refine save function later)

79c8c7b

Store dates as date object

a9e73ff

Merge branch 'branch-Level-8'

c267e54

Kennethsim2000 reviewed Sep 2, 2022

View reviewed changes

alexandermula and others added 14 commits September 4, 2022 03:34

Organise classes into suitable packages

08cf255

abstract read user input to ui class

917c4da

add list command

dafa0e1

add unmark command

ab17e07

add all commands

ee3871e

add parser logic

2b04497

fix parser logic

c453a9a

add TaskList class

0770b6e

add ui logic

8e27eb5

fix storage logic

d930758

clean up packages

ddbd5f6

add storage logic fix parser

Merge branch 'nus-cs2103-AY2223S1:add-gradle-support' into add-gradle…

36fb04e

…-support

add gradle support

b055c54

add junit tests

c225250

hoang227 reviewed Sep 4, 2022

View reviewed changes

Gavzzz reviewed Sep 4, 2022

View reviewed changes

alexandermula added 2 commits September 8, 2022 23:04

Add javadocs for TaskList

d2722ef

Add javadocs to all classes

d88c342

alexandermula and others added 30 commits September 9, 2022 03:42

Add find function

56ab4d6

Merge branch 'branch-A-CodingStandard'

dfc760d

# Conflicts: # src/main/java/chacha/TaskList.java # src/main/java/chacha/commands/ExitCommand.java # src/main/java/chacha/commands/ListCommand.java # src/main/java/chacha/tasks/Deadline.java # src/main/java/chacha/tasks/Todo.java

Merge branch 'branch-Level-9'

59bf323

# Conflicts: # src/main/java/chacha/Ui.java

Add checkstyle

4da3212

Add view and image resources

fd0c357

Add javafx

692246c

add javaFX

4cfda08

add assert statements

2bfa59e

Merge pull request #2 from alexandermula/branch-A-Assertions

0567cc5

add assert statements

fix code quality

e386799

Merge pull request #3 from alexandermula/branch-A-CodeQuality

b668147

fix code quality

Merge pull request #4 from alexandermula/branch-C-Sort

0f7a2fe

Add sort command

Find command: add varargs to pass multiple keywords

1c5c16d

Find command finds returns all tasks with any of the keywords. A find command which accepts multiple arguments is more user-friendly for users who wish to search for multiple types of tasks at once.

Merge branch 'master' of https://github.com/alexandermula/ip

9c75ccf

Merge pull request #5 from alexandermula/branch-C-Sort

bbf40fc

Find command: add varargs to pass multiple keywords

Merge branch 'master' of https://github.com/alexandermula/ip

19c3253

Add enums

ce78d08

Enums control the switch statement in parser. A separate enum class will allow for ease of future additions of commands.

Add styling to GUI

01a6f58

Edit the fxml view files to update styling for GUI. Styling the GUI makes the chatbot more user friendly.

Add personality

ddd0c10

Modify UI responses and error responses to create personality for Chacha. Adding a personality improves user-friendliness of Chacha's interactions with users.

Add github page

a0be07b

Github page as documentation for user. By adding a website, users can easily refer to usage of the product.

Build jar file

81eec33

Replace tabs usage with spaces

9de9aa0

Fix header comments

723befa

Remove dead code

59e259f

Fix package name style

2bf9003

Add test cases

36401c4

Fix header comments

8619248

Fix code quality

4562947

-Fix arrowhead in Chacha getResponse

Fix code quality

ee1e14a

-Fix Parser SLAP

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Singh Abdullah Alexander] iP - #519

[Singh Abdullah Alexander] iP#519
alexandermula wants to merge 58 commits into
nus-cs2103-AY2223S1:masterfrom
alexandermula:master

alexandermula commented Sep 1, 2022 •

edited

Loading

Uh oh!

Kennethsim2000 left a comment

Uh oh!

Kennethsim2000 Sep 2, 2022

Uh oh!

Kennethsim2000 Sep 2, 2022

Uh oh!

Kennethsim2000 Sep 2, 2022

Uh oh!

hoang227 Sep 4, 2022

Uh oh!

hoang227 Sep 4, 2022

Uh oh!

Gavzzz Sep 4, 2022

Uh oh!

Gavzzz Sep 4, 2022

Uh oh!

Gavzzz Sep 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -0,0 +1,102 @@
		package chacha;

		import java.io.BufferedWriter;

Uh oh!

Conversation

alexandermula commented Sep 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chacha

Uh oh!

Kennethsim2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexandermula commented Sep 1, 2022 •

edited

Loading