[Shenyi] iP - #520
Open
ShenyiCui wants to merge 79 commits into
Open
Conversation
- update gitignore to include .class addresses ip-level-1
- add echo to user input - loop cli infinitely addresses ip-level-1
- create a Task class to store items added by the user addresses Level-2 A-Classes
- add function to add tasks - refactor out the greetings message into it's own method - create new method to list tasks addresses Level-2
- allow tasks to be marked as complete and incomplete addresses Level-3
- change mark and unmark output msg addresses Level-3
- add control flow to mark and unmark command addresses Level-3
- add new Class Todo - add new Class Event - add new Class Deadline - make Task abstract addresses Level-4 A-Inheritance
- fix infinite toString recursion error addresses Level-4
- centralise the user output - practice DNR addresses Level-4
- add tests to project addresses A-TextUiTesting
- create custom class DukeException - handle all possible errors addresses Level-5 A-Exceptions
remove taskCount addresses Level-6
- add delete feature addresses Level-6
- add enums for command flags - add enums for TaskTypes addresses A-Enums
- fix code with google-styleguide addresses Level-6
- refactor out logo into static constant addresses Level-6
- add new test cases addresses A-TextUiTesting
- update .gitignore to ignore vscode files addresses Level-6
- refactor java styles addresses Level-6
- move logic for commands from Duke to Command enum class - Add javadocs for respective classes addresses week-2-refactor
- remove unused Commands file addresses week-2-refactor
- add skeleton code for AllTaskList to track all Tasks addresses week-2-refactor
- finish moving logic of commands from Duke to Command addresses week-2-refactor
- refactor method to throw DukeException instead of IndexOutOfBounds addresses week-2-refactor
- move error handling to chat instead of main addresses week-2-refactor
- add a common super constructor to create the "task" string addresses week-2-refactor
- refactor output to user for add and delete addresses week-2-refactor
- create uniform execption handling with DukeException addresses week-2-refactor
Josephaedan
reviewed
Sep 3, 2022
Josephaedan
left a comment
Josephaedan
left a comment
There was a problem hiding this comment.
Overall your code looks great! I think you have followed the coding standards for the most part across all your commits and I only had a few minor suggestions. Keep up the good work!
| private static final String STORAGE_PATH = "storage/storage.txt"; | ||
|
|
||
| /** | ||
| * Method used to init the duke.Storage on a device, creating the directory and file if it doesn't exist. |
There was a problem hiding this comment.
Not much to comment here, but perhaps you could consider being a little more specific about what initStorage() does in your description?
| import java.io.Serializable; | ||
|
|
||
| /* | ||
| * Abstract super class of all Tasks. |
There was a problem hiding this comment.
Perhaps you could add the properties of the Task class here as explanation in your documentation
eg. @param task, @param isComplete
- use java fxml to build UI - integrated SceneBuilder
add assertion for user input
refactor code to improve code-quality
add view schedule
- add ci/cd that checks for compilation on pushes and pull requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duke
DukePro frees your mind from having to remember things you need to do.
Features
Installation
java -jar duke.jarAnd it is FREE!
Upcoming Features