[Francis Tan] iP - #522
Open
Francis-Tan wants to merge 37 commits into
Open
Conversation
…ead of reading the input itself, now read words from the input split by " ", to make code more readable
…ags/datetimes, invalid args for un/mark
…nds, along with more javadocs
…tasks and services
…ifted static methods over to them
…n optional (h:mm)am/pm, and the description shows the month in english
…nder new timing format
rui-han-crh
reviewed
Sep 2, 2022
rui-han-crh
left a comment
rui-han-crh
left a comment
There was a problem hiding this comment.
Very nice! Code is clean and readable, good amount of test cases to cover many bases.
| package duke.services; | ||
|
|
||
| /** Handles display */ | ||
| public class UI { |
There was a problem hiding this comment.
Perhaps the name of this class would be better written as Ui, to conform to the coding standard?
Comment on lines
+27
to
+49
| if (words.length == 1 && words[0].equals("list")) { | ||
| TaskList.listTasks(); //could put words.length == 1 cases all here | ||
| } else if (words.length == 1 && words[0].equals("SAVE")) { | ||
| Storage.wipeDataOnExit(false); | ||
| } else if (words.length == 1 && words[0].equals("WIPE")) { | ||
| Storage.wipeDataOnExit(true); | ||
| } else if (words[0].equals("todo")) { | ||
| TaskList.addTodo(words); | ||
| } else if (words[0].equals("deadline")) { | ||
| TaskList.addDeadline(words); | ||
| } else if (words[0].equals("event")) { | ||
| TaskList.addEvent(words); | ||
| } else if (words[0].equals("mark")) { | ||
| TaskList.markTaskAsDone(words); | ||
| } else if (words[0].equals("unmark")) { | ||
| TaskList.markTaskAsNotDone(words); | ||
| } else if (words[0].equals("delete")) { | ||
| TaskList.deleteTask(words); | ||
| } else if (words[0].equals("find")) { | ||
| TaskList.findTasksContainingKeyword(words); | ||
| } else { | ||
| UI.sayLines(new String[]{"I'm sorry, I don't know what that means"}); | ||
| } |
There was a problem hiding this comment.
Perhaps a switch statement would be more conventional for readibility here?
| */ | ||
| public static void handleUserInputs() { | ||
| Scanner inputScanner = new Scanner(System.in); | ||
| String[] words = Arrays.stream(inputScanner.nextLine().strip().split(" ")).toArray(String[]::new); |
There was a problem hiding this comment.
Nice application of declarative input consumption and splitting here! :)
| assertEquals(Parser.getDescription(deadline1, "/by"), "finish essay"); | ||
| assertEquals(Parser.getTiming(deadline1, "/by"), "tmr night or ask 4 extension"); | ||
| //does it throw exception for missing all other arguments? | ||
| assertThrows(IllegalArgumentException.class, () -> |
There was a problem hiding this comment.
I like how you also decided to test the exceptions here!
But this test case may be testing too many things at the same time, perhaps split these tests into more subgroups? Like
testGetDescription_event, testGetDescription_deadline, testGetDescriptionAndDate_throwsIllegalArgumentException, etc
Refactored code by making Duke, rather than the parser, decide how to respond to inputs, and merged UI with Duke, since UI was in charge of too little functionality that Duke could also handle reasonably. Broke down a very long test case into smaller test cases.
Improve code quality
# Conflicts: # src/main/java/duke/services/Duke.java # src/main/java/duke/services/Parser.java # src/main/java/duke/services/Storage.java
and number of time attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duke
Duke frees your mind of having to remember things you need to do. It's
FastSUPER FAST to useAll you need to do is
And it is FREE!
Features:
If you're a Java programmer, you can use it to practice Java too. Here's the main method: