feat: Include individual text values for each font#149
Conversation
|
I just realized that this could also be implemented in google-fonts-helper. Not sure which way would be better. |
ricardogobbosouza
left a comment
ricardogobbosouza
left a comment
There was a problem hiding this comment.
Hi @jakubkoje
Thanks for the PR, I made some observations
You also need to add tests 😄
| } | ||
| }) | ||
|
|
||
| logger.start('Downloading fonts...') |
There was a problem hiding this comment.
Add outside for
|
|
||
| logger.start('Downloading fonts...') | ||
| await downloader.execute() | ||
| logger.success('Download fonts completed.') |
There was a problem hiding this comment.
Add outside for
| // Disable sanitazions | ||
| // @ts-ignore | ||
| head.__dangerouslyDisableSanitizersByTagID = head.__dangerouslyDisableSanitizersByTagID || {} | ||
| // @ts-ignore | ||
| head.__dangerouslyDisableSanitizersByTagID['gf-script'] = ['innerHTML'] | ||
| // @ts-ignore | ||
| head.__dangerouslyDisableSanitizersByTagID['gf-noscript'] = ['innerHTML'] |
There was a problem hiding this comment.
Add outside for
| for (const url of urls) { | ||
| head.script.push({ | ||
| key: 'gf-script', | ||
| innerHTML: `(function(){var l=document.createElement('link');l.rel="stylesheet";l.href="${url}";document.querySelector("head").appendChild(l);})();` |
There was a problem hiding this comment.
Maybe create a script to create the stylesheet.
In case of several url this script will be duplicated.
| children: `(function(){ | ||
| var h=document.querySelector("head"); | ||
| var m=h.querySelector('meta[name="head:count"]'); | ||
| if(m){m.setAttribute('content',Number(m.getAttribute('content'))+1);} | ||
| else{m=document.createElement('meta');m.setAttribute('name','head:count');m.setAttribute('content','1');h.append(m);} | ||
| var l=document.createElement('link');l.rel='stylesheet';l.href='${url}';h.appendChild(l); | ||
| })();` |
There was a problem hiding this comment.
Maybe create a script to create the stylesheet.
In case of several url this script will be duplicated.
|
so is it possible rn? |
Not yet. I don't have much time right now to continue with this pull request, help would be appreciated. |
3 participants
Current Situation:
Currently, as reported in #106, it is not possible to include only the requested text for each individual font. The current implementation fetches the entire font data in one call, and there is no way to specify separate text values for each font using the Google API.
Proposed Solution:
To enable this feature, we need to modify the font fetching process and split it into separate calls. By doing so, we can include only the requested text for each font. This adjustment will ensure that the Google API can handle separate text values for individual fonts.
I would love to someone who is more experienced with Nuxt modules to check if the downloading still works as expected.