Skip to content

Use Deferred thunks for 0-size arrays when testing #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manopapad wants to merge 3 commits into
base: branch-24.03
Choose a base branch
from
Open

Use Deferred thunks for 0-size arrays when testing #530

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e111942
Use Deferred thunks for 0-size arrays when testing
manopapad Aug 12, 2022
0afde42
Merge branch 'branch-22.10' into zero-size-deferred
manopapad Aug 22, 2022
a1f3148
Merge branch 'branch-22.12' into zero-size-deferred
manopapad Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cunumeric/runtime.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,12 +589,12 @@ def create_unbound_thunk(

def is_eager_shape(self, shape: NdShape) -> bool:
volume = calculate_volume(shape)
# Newly created empty arrays are ALWAYS eager
if volume == 0:
return True
# If we're testing then the answer is always no
if self.args.test_mode:
return False
# Newly created empty arrays are ALWAYS eager
if volume == 0:
return True
if len(shape) > LEGATE_MAX_DIM:
return True
if len(shape) == 0:
Expand Down