Replace AIMaster m_lEventQueue with a priority queue#1537
Open
Liareth wants to merge 4 commits intonwnxee:masterfrom
Open
Replace AIMaster m_lEventQueue with a priority queue#1537Liareth wants to merge 4 commits intonwnxee:masterfrom
Liareth wants to merge 4 commits intonwnxee:masterfrom
Conversation
Daztek
reviewed
Aug 14, 2022
Member
Daztek
left a comment
Daztek
left a comment
There was a problem hiding this comment.
Just a bunch of minor things, also don't forget to update CHANGELOG.md!
mtijanic
approved these changes
Aug 15, 2022
Contributor
|
Any reason this was never merged? |
Yeah: I got RL'd, then forgot about it. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big optimization if your module has a lot of queued events (many areas, many delaycommands, lots of fighting, lots of effects, etc). Previously events that were not immediate would be added to the linked list in
AddEventAbsoluteTimeViaTailwhich would iterate backwards over every calendar entry until it found a place to insert.Side effect: Events with the same time of day are now executed in an undefined order. E.g:
Who knows which one will happen first? I certainly don't. But if you don't care about that, and your server is big and full of events, this could be a valuable optimization for you.