Attempt nvidia-device-plugin app fixes

Author: nwthomas

helm/nvidia-device-plugin/Chart.yaml

@@ -3,4 +3,4 @@ name: nvidia-device-plugin
 description: NVIDIA Device Plugin for Kubernetes
 type: application
 version: 0.1.0
-appVersion: "v0.17.1"
+appVersion: "v0.18.0"

helm/nvidia-device-plugin/templates/daemonset.yaml

@@ -25,7 +25,7 @@ spec:
       - image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
         imagePullPolicy: {{ .Values.image.pullPolicy }}
         name: nvidia-device-plugin-ctr
-        args: ["--fail-on-init-error=false"]
+        command: ["nvidia-device-plugin"]
         securityContext:
           {{- toYaml .Values.securityContext | nindent 10 }}
         resources:
@@ -35,8 +35,19 @@ spec:
         env:
         - name: PASS_DEVICE_SPECS
           value: "true"
+        {{- if typeIs "bool" .Values.failOnInitError }}
+        - name: FAIL_ON_INIT_ERROR
+          value: {{ .Values.failOnInitError | quote }}
+        {{- else }}
         - name: FAIL_ON_INIT_ERROR
           value: "false"
+        {{- end }}
+        {{- if typeIs "string" .Values.deviceDiscoveryStrategy }}
+        {{- if ne .Values.deviceDiscoveryStrategy "" }}
+        - name: DEVICE_DISCOVERY_STRATEGY
+          value: {{ .Values.deviceDiscoveryStrategy }}
+        {{- end }}
+        {{- end }}
         {{- if .Values.env }}
         {{- toYaml .Values.env | nindent 8 }}
         {{- else }}
@@ -50,5 +61,4 @@ spec:
           value: "compute,utility"
         {{- end }}
       volumes:
-        {{- toYaml .Values.volumes | nindent 8 }}
-      hostNetwork: true
+        {{- toYaml .Values.volumes | nindent 8 }}

helm/nvidia-device-plugin/values.yaml

@@ -3,6 +3,12 @@ image:
   tag: v0.18.0
   pullPolicy: IfNotPresent
 
+failOnInitError: false
+
+# Device discovery strategy: "auto", "cdi", or "legacy"
+# Leave empty/null to use default "auto"
+deviceDiscoveryStrategy: ""
+
 nodeSelector:
   kubernetes.io/arch: amd64
   gpu: "true"