Lets user see his own comments#529
Open
spanishharlem wants to merge 7 commits intonyaadevs:masterfrom
spanishharlem:comments
Open
Lets user see his own comments#529spanishharlem wants to merge 7 commits intonyaadevs:masterfrom spanishharlem:comments
spanishharlem wants to merge 7 commits intonyaadevs:masterfrom
spanishharlem:comments
Conversation
TheAMM
suggested changes
Oct 25, 2018
| if not flask.g.user or not flask.g.user.is_moderator: | ||
| if user == flask.g.user: | ||
| pass | ||
| elif not flask.g.user or not flask.g.user.is_moderator: |
Contributor
There was a problem hiding this comment.
Much better as
# Only moderators and users themselves get to see the comments
if not flask.g.user or not (flask.g.user == user or flask.g.user.is_moderator):
flask.abort(403)
TheAMM
reviewed
Oct 26, 2018
| <nyaa:categoryId>{{- cat_id }}</nyaa:categoryId> | ||
| <nyaa:category> {{- category_name(cat_id) }}</nyaa:category> | ||
| <nyaa:size> {{- torrent.filesize | filesizeformat(True) }}</nyaa:size> | ||
| <nyaa:comments> {{- torrent.comment_count }}</nyaa:comments> |
Contributor
There was a problem hiding this comment.
You're now including the comment count from the other PR!
Contributor
Author
There was a problem hiding this comment.
I'm not even sure how did it end up here, ehh.
|
Will this ever get pushed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an "View all comments" option to profile page (/profile/comments), working the same as admin tool.