Open
Conversation
Updated to allow actions to disable/enable buttons using TinyMCE4. Also added a couple menu items for accept and reject.
without this if you turn off track changes then the editor does not process deletes and backspaces
enables default backspace and delete key when ICE is not tracking
Updated plugin to allow disable/enable buttons
…tinymce 4 folder structure. seems like not a whole lot of compatibility differences between 3.5 and 4 (so far)
Test the merge of CatsGotMyTonge's fork of Ice (TinyMCE v4 changes) with the upstream master (NYTimes)
|
@DNWEIJ were you able to solve this issue? I am looking at the updated code now and cannot get it to compile correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changed lib to tinymce5
changed the two ice pugins
no changed to ice code
added icons since only svg are supported in 5
It seems there is an issue with the inline editor. I have created a bug:
tinymce/tinymce#5384
Am investigating if i can use the general init method of tinymce5:
init_instance_callbackto work around it.