Open
Conversation
Add COBOL to the supported languages list with ASCII art featuring the COBOL letterform and a classic IDENTIFICATION DIVISION header. Uses blue color matching the IBM mainframe heritage. Closes o2sh#1443
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
I think the empty lines in the ASCII art can be removed. Otherwise, LGTM.
languages.yaml
Outdated
Comment on lines
+404
to
+415
| {0} | ||
| {0} CCCC OOOOO BBBBB OOOOO LL | ||
| {0} CC CC OO OO BB BB OO OO LL | ||
| {0} CC OO OO BBBBB OO OO LL | ||
| {0} CC CC OO OO BB BB OO OO LL | ||
| {0} CCCC OOOOO BBBBB OOOOO LLLLLL | ||
| {0} | ||
| {0} ================================================ | ||
| {0} IDENTIFICATION DIVISION. | ||
| {0} PROGRAM-ID. ONEFETCH. | ||
| {0} ================================================ | ||
| {0} |
Collaborator
There was a problem hiding this comment.
Suggested change
| {0} | |
| {0} CCCC OOOOO BBBBB OOOOO LL | |
| {0} CC CC OO OO BB BB OO OO LL | |
| {0} CC OO OO BBBBB OO OO LL | |
| {0} CC CC OO OO BB BB OO OO LL | |
| {0} CCCC OOOOO BBBBB OOOOO LLLLLL | |
| {0} | |
| {0} ================================================ | |
| {0} IDENTIFICATION DIVISION. | |
| {0} PROGRAM-ID. ONEFETCH. | |
| {0} ================================================ | |
| {0} | |
| {0} CCCC OOOOO BBBBB OOOOO LL | |
| {0} CC CC OO OO BB BB OO OO LL | |
| {0} CC OO OO BBBBB OO OO LL | |
| {0} CC CC OO OO BB BB OO OO LL | |
| {0} CCCC OOOOO BBBBB OOOOO LLLLLL | |
| {0} | |
| {0} ================================================ | |
| {0} IDENTIFICATION DIVISION. | |
| {0} PROGRAM-ID. ONEFETCH. | |
| {0} ================================================ |
spenserblack
requested changes
Apr 13, 2026
Collaborator
spenserblack
left a comment
spenserblack
left a comment
There was a problem hiding this comment.
After checking, I realized the CI is failing because the wrong language name was used.
- Rename to match tokei::LanguageType::Cobol variant - Compress letter spacing to stay within 40-char line width - Remove empty lines per review feedback - Shorten separator bars to fit constraint Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Fixed in 332742e:
Build passes locally with |
spenserblack
requested changes
Apr 13, 2026
spenserblack
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds COBOL to onefetch's supported languages.
languages.yaml: Added COBOL entry with:tokei already supports COBOL for line counting.
Closes #1443
This contribution was developed with AI assistance (Claude Code).