added svg to png export as image file#60
Open
IvanSladkov wants to merge 4 commits intodevelopfrom
Open
Conversation
archived-m
reviewed
Dec 4, 2018
|
|
||
| saveSvgAsPng(document.querySelector('svg'), name + '.png'); | ||
|
|
||
| // Print telkens maar een deel van het svg af om een of andere reden |
Collaborator
There was a problem hiding this comment.
Comment can be removed
archived-m
requested changes
Dec 4, 2018
Collaborator
archived-m
left a comment
archived-m
left a comment
There was a problem hiding this comment.
- Why is there an export for Sunburst, but not overlap?
- The export of the sunburst in its current state doesn't tell the user anything. I think should include a legend of at least the colours, otherwise you're just looking at a graph without meaning
- The "export" button is just floating about somewhere beneath the sunburst, I'd position it somewhere such as beneath the info box
archived-m
reviewed
Dec 13, 2018
Collaborator
archived-m
left a comment
archived-m
left a comment
There was a problem hiding this comment.
Nice, do you think you can still manage the color legend for the sunburst export?
Collaborator
Author
|
Yeah, right now I'm looking for a way to incorporate a legend in the export. But the library only converts svg files, so I'll have to find a workaround for that. |
Collaborator
|
@IvanSladkov Any update on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.