runtime-sdk: Add provider-related endorsement constraints - #2241
Merged
Conversation
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
from
June 18, 2025 13:03
980de54 to
354ff3b
Compare
kostko
force-pushed
the
kostko/feature/rofl-scheduler-api-logs
branch
3 times, most recently
from
June 20, 2025 07:10
4ab4045 to
32f0c68
Compare
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
from
June 20, 2025 11:53
354ff3b to
47e3153
Compare
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
2 times, most recently
from
June 23, 2025 09:55
51dfdad to
d63d5a5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2241 +/- ##
==========================================
- Coverage 55.06% 53.38% -1.69%
==========================================
Files 160 162 +2
Lines 12109 12230 +121
==========================================
- Hits 6668 6529 -139
- Misses 5441 5701 +260 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
2 times, most recently
from
June 27, 2025 13:29
5a640aa to
30ff9c8
Compare
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
2 times, most recently
from
July 10, 2025 13:01
211e6c7 to
ce44e94
Compare
kostko
marked this pull request as ready for review
July 10, 2025 13:09
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
from
July 10, 2025 14:02
ce44e94 to
bf791d9
Compare
peternose
reviewed
Jul 11, 2025
| /// Provider attestation metadata stored in `METADATA_KEY_POLICY_PROVIDER_ATTESTATION` label. | ||
| #[derive(Clone, Debug, Default, cbor::Encode, cbor::Decode)] | ||
| pub struct ProviderAttestation { | ||
| /// A CBOR-serialized `LabelAttestation`. |
Collaborator
There was a problem hiding this comment.
In other structs you used name attestation and comment CBOR-serialized label attestation..
| }; | ||
|
|
||
| // Include provider-specific metadata if available. | ||
| if let Err(err) = self.collect_provider_metadata(&mut metadata).await { |
Collaborator
There was a problem hiding this comment.
[nit] Might be more readable if we renamed this function to fetch_provider_metadata and then insert it here, as currently the reader has no idea what is going on with metadata.
|
|
||
| Self::verify_atoms( | ||
| ctx, | ||
| EndorsementPolicyOperator::Or, |
Collaborator
There was a problem hiding this comment.
If it is not important which operator we insert here, I would try to remove it from function signature?
Member
Author
There was a problem hiding this comment.
It is not important in this particular invocation (because the default for outer-most atoms is OR), but that function is also called from other places where this can be AND (e.g. when evaluating the And operator).
Collaborator
There was a problem hiding this comment.
Yes, but veriify_atoms is a public function of the trait, so it should not have this parameter (inner ones can have it).
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
from
July 11, 2025 10:10
bf791d9 to
a262b93
Compare
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
2 times, most recently
from
July 11, 2025 11:33
6c30106 to
74589b3
Compare
peternose
approved these changes
Jul 11, 2025
kostko
force-pushed
the
kostko/feature/rofl-app-provider-constraints
branch
from
July 11, 2025 11:53
74589b3 to
60025cd
Compare
github-actions Bot
added a commit
that referenced
this pull request
Jul 11, 2025
…ostko/feature/rofl-app-provider-constraints runtime-sdk: Add provider-related endorsement constraints 39703f7
github-actions Bot
added a commit
that referenced
this pull request
Jul 11, 2025
…/kostko/feature/rofl-app-provider-constraints runtime-sdk: Add provider-related endorsement constraints 39703f7
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jul 11, 2025
…oasisprotocol/kostko/feature/rofl-app-provider-constraints runtime-sdk: Add provider-related endorsement constraints 39703f7
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Jul 11, 2025
…sisprotocol/kostko/feature/rofl-app-provider-constraints runtime-sdk: Add provider-related endorsement constraints 39703f7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2237