accounting: encrypt AuthToken key sync - #151
Merged
uniyalabhishek merged 1 commit intoMay 18, 2026
Merged
Conversation
uniyalabhishek
requested review from
ahmedhamedaly,
matevz,
ptrus and
rube-de
as code owners
May 18, 2026 10:59
matevz
reviewed
May 18, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/security/rofl-auth-token-key-sync
branch
from
May 18, 2026 14:52
a1a6c3c to
860f7f4
Compare
matevz
approved these changes
May 18, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/security/rofl-auth-token-key-sync
branch
from
May 18, 2026 16:04
d674fa9 to
a267e9e
Compare
uniyalabhishek
deleted the
uniyalabhishek/security/rofl-auth-token-key-sync
branch
May 18, 2026 16:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypt ROFL transaction submission by default and require explicit allow-listing for any plaintext opt-out.
Ensure AuthToken key sync uses the encrypted path, fails closed on startup errors, and no longer logs key material.
If any production key sync may have already happened unencrypted, rotate
_authTokenEncKeyafter deploy. I think we are only on testnet so far, so it should be ok.