accounting: complete user history coverage - #153
Merged
Conversation
uniyalabhishek
marked this pull request as ready for review
May 22, 2026 20:59
uniyalabhishek
requested review from
ahmedhamedaly,
matevz,
ptrus and
rube-de
as code owners
May 22, 2026 20:59
matevz
reviewed
May 25, 2026
uniyalabhishek
changed the title
matevz
reviewed
May 26, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
2 times, most recently
from
June 1, 2026 08:24
2d6a467 to
662a649
Compare
This was referenced Jun 4, 2026
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
from
June 11, 2026 07:55
662a649 to
7fc8dc5
Compare
uniyalabhishek
marked this pull request as draft
June 11, 2026 08:01
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
from
June 11, 2026 09:50
7fc8dc5 to
05e7402
Compare
uniyalabhishek
changed the title
uniyalabhishek
changed the title
Contributor
Author
|
Rebuilt from scratch on master, see the updated description. |
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
from
June 11, 2026 13:59
05e7402 to
93531de
Compare
uniyalabhishek
marked this pull request as ready for review
June 11, 2026 13:59
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
from
June 11, 2026 19:12
93531de to
79a9cd5
Compare
matevz
reviewed
Jun 12, 2026
matevz
left a comment
matevz
left a comment
Member
There was a problem hiding this comment.
I suggest some further simplifications.
uniyalabhishek
force-pushed
the
uniyalabhishek/feat/accounting-history
branch
from
June 15, 2026 07:59
fb47f13 to
9b7367d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #149.
Completes user history coverage in
Accountingdirectly. The delegatecall history module is unnecessary now that oasisprotocol/oasis-sdk#2471 raised Sapphire's code limit to 64 KiB.HistoryKindgainsModifyLock,UnlockLock, and directional transfer kindsTransferFromLockOut/InandTransferBalanceOut/In. Nothing durable is deployed, so it is renumbered cleanly with no legacy decode path.transferFromLock/transferBalancewrite one 84-bytetokenId|amount|counterpartyrow per participant. The sender'sOutrow carries the recipient, the recipient'sInrow the sender. TheInrow is skipped for zero-address and self transfers.modifyLockrecords the locked-amount delta (0 for expiry-only changes). Single and batch unlocks record oneUnlockLockper lock.from_address/to_addresssince direction now lives in the kind. Unrecognized kinds degrade tounknown.Accountingis 27,024 bytes, over EIP-170 but well under the 64 KiB limit now live on Sapphire Testnet1.3.0-testnet.