Skip to content

docs: Update quickstart code references - #359

Closed
aefhm wants to merge 1 commit into
mainfrom
xz/351-update-code-snippets
Closed

docs: Update quickstart code references#359
aefhm wants to merge 1 commit into
mainfrom
xz/351-update-code-snippets

Conversation

@aefhm

@aefhm aefhm commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

Description

After Viem and Wagmi V2 changes in #303, some code examples are out of date. Closes #351

@aefhm aefhm self-assigned this Aug 23, 2024
@netlify

netlify Bot commented Aug 23, 2024

Copy link
Copy Markdown

Deploy Preview for oasisprotocol-sapphire-paratime ready!

Name Link
🔨 Latest commit c6c3fc2
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-sapphire-paratime/deploys/66d525c4140afd000804781e
😎 Deploy Preview https://deploy-preview-359--oasisprotocol-sapphire-paratime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz

matevz commented Aug 30, 2024

Copy link
Copy Markdown
Member

Instead of using commit hashes, should we make the clients/js/stable/1.x branch instead? This is also useful, if we needed to backport anything until 2.x is stable.

@aefhm

aefhm commented Aug 30, 2024

Copy link
Copy Markdown
Contributor Author

Instead of using commit hashes, should we make the clients/js/stable/1.x branch instead? This is also useful, if we needed to backport anything until 2.x is stable.

In which case, I think we would branch off this commit? I think main is quite a bit ahead by now. Would this slightly more readable alternative (than just a commit SHA) be reasonable?

@aefhm
aefhm force-pushed the xz/351-update-code-snippets branch from abaa6c2 to 7fae116 Compare August 30, 2024 21:46
@aefhm
aefhm force-pushed the xz/351-update-code-snippets branch from 7fae116 to c6c3fc2 Compare September 2, 2024 02:41
@aefhm aefhm added docs Documentation javascript Pull requests that update JavaScript code labels Sep 2, 2024
@aefhm

aefhm commented Sep 4, 2024

Copy link
Copy Markdown
Contributor Author

Superceded by #378

@aefhm aefhm closed this Sep 4, 2024
@aefhm
aefhm deleted the xz/351-update-code-snippets branch September 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation javascript Pull requests that update JavaScript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Sapphire quickstart guide: vigil.sol and run-vigil.ts links broken

2 participants