Skip to content

Refactor Tooltip component - #27

Merged
buberdds merged 5 commits into
masterfrom
mz/tooltip
Jul 24, 2025
Merged

Refactor Tooltip component #27
buberdds merged 5 commits into
masterfrom
mz/tooltip

Conversation

@buberdds

@buberdds buberdds commented Jun 4, 2025

Copy link
Copy Markdown
Collaborator

Closes #24

https://pr-27.oasis-ui.pages.dev/?path=/docs/components-tooltip--docs&globals=theme:light
vs current
https://oasis-ui.pages.dev/?path=/docs/components-tooltip--docs&globals=theme:light

  • adjust styles
  • add interaction to play function (hopefully this is will be used in regression tests more in the future)
  • API changes:
<Tooltip title="Tooltip content">
  <Button variant="outline">
    Hover me
  </Button>
</Tooltip>

instead of

<Tooltip>
  <>
    <TooltipTrigger>
      <Button variant="outline">
        Hover me
      </Button>
    </TooltipTrigger>
    <TooltipContent>
        Tooltip content
    </TooltipContent>
  </>
</Tooltip>

@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

Deployed to Cloudflare Pages

Latest commit: 8812c6a3dc48b5a3f0c32f34d35be555081eb19c
Status:✅ Deploy successful!
Preview URL: https://5bb42d94.oasis-ui.pages.dev
Alias: https://pr-27.oasis-ui.pages.dev

@buberdds buberdds changed the title Refactor component API Refactor Tooltip component Jun 4, 2025
@buberdds
buberdds force-pushed the mz/tooltip branch 3 times, most recently from eb23dab to 100cc2b Compare June 4, 2025 09:58
@buberdds
buberdds marked this pull request as ready for review June 4, 2025 10:53
@buberdds
buberdds requested review from csillag, lubej and lukaw3d June 4, 2025 11:51

@lubej lubej left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not in favor of modifying the original components of shadcn. As the docs we will be referring to are still the original dev docs. I would rather see we would create wrapper version of the component. Especially if we are going to use generation tools, which would always generate "wrong" tooltip, and would always require manual changes. Can we maybe discuss this in more detail on next FE sync, on how to manage "custom" components?

@buberdds

buberdds commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator Author

Sure let's chat tomorrow.

For now I can bring back original tooltip and add wrapper as a separate component. For generation tools no clue how they gonna work.

@buberdds
buberdds force-pushed the mz/tooltip branch 3 times, most recently from 95f02b5 to 1a35695 Compare June 9, 2025 09:01
@buberdds

buberdds commented Jun 9, 2025

Copy link
Copy Markdown
Collaborator Author

For Sync meeting:

  1. how we want to handle custom components (where to store them/naming convention/export names etc).
    For clear separation maybe current componets/ui would be more like base components (not imported) in apps?

  2. what are boundaries of auto generated components customization?

@buberdds
buberdds merged commit 50d6b72 into master Jul 24, 2025
4 checks passed
@buberdds
buberdds deleted the mz/tooltip branch July 24, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor Tooltip component

2 participants