Make z-index of Select very very high - #73
Merged
Merged
Conversation
Deployed to Cloudflare Pages
|
Contributor
Author
|
hm, this official shadcn example appears to use sticky header with default z-index https://ui.shadcn.com/view/sidebar-02 so maybe we should change explorer instead |
Contributor
Author
|
default z-index for sticky header sounds very error prone tho |
buberdds
reviewed
Oct 2, 2025
| data-slot="select-content" | ||
| className={cn( | ||
| 'bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 relative z-50 max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-md border shadow-md', | ||
| 'bg-popover text-popover-foreground data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2 relative z-99999999999 max-h-(--radix-select-content-available-height) min-w-[8rem] origin-(--radix-select-content-transform-origin) overflow-x-hidden overflow-y-auto rounded-md border shadow-md', |
Collaborator
There was a problem hiding this comment.
- this is misleading as value used in a browser will be different. There is no such class in Tailwind so this will end up with -> Tailwind's JIT -> exceeds JavaScript's safe integer range
- can we use z-[9999] (in general arbitrary values are in square brackets in tailwind)
- optional:
uifolder was auto-generated. there is customize select incomponents/selectfolder where we override "base" select
Contributor
Author
There was a problem hiding this comment.
+1
I don't know how to differentiate arbitrary value vs tailwind pre-generated values. https://tailwindcss.com/docs/z-index doesnt say
lukaw3d
force-pushed
the
lw/select-zindex
branch
from
October 8, 2025 10:24
5a52438 to
f1e7c76
Compare
I think radix primitive inside Select always calculates available height as whole screen. So it might place items underneath other z-index elements and make them unreachable. In explorer could not select Transfer method under topbar.
lukaw3d
force-pushed
the
lw/select-zindex
branch
from
October 8, 2025 11:07
f1e7c76 to
d9c39e0
Compare
buberdds
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think radix primitive inside Select always calculates available height as whole screen. So it might place items underneath other z-index elements and make them unreachable. In explorer can not select Transfer method:
https://explorer.dev.oasis.io/testnet/sapphire/address/oasis1qzd4lct2jgtnaysz22g2ujgww63y6dsc5vxjdk4w?tx_method=
This high z-index might cause other issues: do shadcn alerts expect to be displayed over select when they make everything unclickable? 🤷