ARTART: clarify PBES2 p2c rejection threshold (Section 3.13)#48
Closed
yaronf wants to merge 1 commit into
Closed
Conversation
Tie rejection to the configured upper limit and explain that the OWASP example illustrates a reasonable choice for that limit. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Closing without merge. After author review, we prefer the original wording; see comment on #45. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses ARTART review comment #4 from @smyslov on Section 3.13 (Limit Hash Iteration Count).
The previous text had two RECOMMENDED clauses whose relationship was ambiguous: an upper limit on iterations vs. rejecting
p2cvalues larger than "twice that figure" (unclear whether "that figure" meant the limit or the OWASP example).This rewrite:
p2cvalues exceeding their configured upper limit-07document history entryIssues
Closes #45
Test plan
makebuilds successfullyNote
This PR is independent of #47 (Section 3.11). Both add a
-07history entry; these will need to be merged into a single entry when both land.Made with Cursor