some nitpicks and clarifications#295
Merged
Merged
Conversation
c2bo
approved these changes
Jun 23, 2025
c2bo
requested changes
Jun 23, 2025
tplooker
approved these changes
Jun 23, 2025
tplooker
left a comment
tplooker
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with Christians proposed change around JSON string incorperated.
paulbastian
commented
Jun 23, 2025
c2bo
approved these changes
Jun 23, 2025
tplooker
force-pushed
the
comments_by_denis_3
branch
from
July 4, 2025 06:33
444229f to
4fb1686
Compare
tplooker
reviewed
Jul 7, 2025
Collaborator
|
Multiple reviews based on the underlying issue #294. As editors we feel we have addressed all the concerns raised. The PR now has multiple approvals and has been open 2 weeks. Merging. |
tplooker
added a commit
that referenced
this pull request
Jul 17, 2025
some nitpicks and clarifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294