Editorial fixes for kramdown etc.#357
Conversation
2d46db3 to
cb41772
Compare
starrant-rpc
left a comment
starrant-rpc
left a comment
There was a problem hiding this comment.
I've added some comments that might help with idnits -- "might" meaning that I hope it will.
| email: chris.bormann@gmx.de | ||
|
|
||
| normative: | ||
| RFC1950: RFC1950 |
There was a problem hiding this comment.
Note that "RFC1950: RFC1950" can be just "RFC1950".
There was a problem hiding this comment.
These two references should be formatted like this instead:
From:
SD-JWT.VC: I-D.ietf-oauth-sd-jwt-vc
SD-CWT: I-D.ietf-spice-sd-cwt
To
I-D.ietf-oauth-sd-jwt-vc: SD-JWT.VC
I-D.ietf-spice-sd-cwt: SD-CWT
After this change, the body of the source should also be updated so that the "I-D.ietf-xxx" is in place instead of the "SD-xx" tags.
|
|
||
| encoded (hex): | ||
|
|
||
| ~~~ hex |
There was a problem hiding this comment.
Since "hex" does not appear on the short (https://rpc-wiki.rfc-editor.org/rpc/wiki/doku.php?id=sourcecode-types) or long (https://www.iana.org/assignments/media-types/media-types.xhtml) list, I'd advise to simply leave the code blocks marked "hex" blank.
There was a problem hiding this comment.
I'd advise the same for "compact-jwt".
| The following OID is defined for usage in the EKU extension: | ||
|
|
||
| ~~~ | ||
| ~~~ ASN.1 |
There was a problem hiding this comment.
Update "ASN.1" (capitalized) to "asn.1" (lowercase).
There was a problem hiding this comment.
And throughout in the other code blocks :)
|
|
||
| ~~~ cddl | ||
| StatusList = { | ||
| bits: 1 / 2 / 4 / 8, ; The number of bits used per Referenced Token |
There was a problem hiding this comment.
This line appears to be longer than 72 characters (maybe 2 characters too long?).
| a502782168747470733a2f2f # "¥\x02x!https://" | ||
| 6578616d706c652e636f6d2f # "example.com/" | ||
| 7374617475736c697374732f # "statuslists/" | ||
| 31061a648c5bea041a8898df # "1\x06\x1ad\x8c[ê\x04\x1a\x88\x98ß" |
There was a problem hiding this comment.
This line appears to be longer than 72 characters (maybe 6 characters?).
| 340f7efea10f1a36dc479763 # "4\x0f~þ¡\x0f\x1a6ÜG\x97c" | ||
| 6a17b4dd4848b68997d1d10e # "j\x17´ÝHH¶\x89\x97ÑÑ\x0e" | ||
| 8cceb3a38ff33b3dda72964a # "\x8cγ£\x8fó;=Úr\x96J" | ||
| 83989f6cf98560c2fc97a08b # "\x83\x98\x9flù\x85`Âü\x97\xa0\x8b" |
There was a problem hiding this comment.
This line appears to be longer than 72 characters (maybe 6?).
| Bit Values |1|0|1|1|1|0|0|1| |1|0|1|0|0|0|1|1| | ||
| +-+-+-+-+-+-+-+-+ +-+-+-+-+-+-+-+-+ | ||
| List Index 7 6 5 4 3 2 1 0 15 ... 10 9 8 | ||
| \_______________/ \_______________/ |
There was a problem hiding this comment.
Some errors in idnits might be related to the "" back slashes -- even in ascii artwork and code blocks. But I think we can work around it.
…ietf-oauth-status-list into editorial-fixes-kramdown
|
this version should be fine now the cbor annotated hex tooling (cbor-pretty) is imho still somewhat lacking and I couldn't find a single tool that adheres to width limits properly -> i decided to replace the comments that were going over length with "...". |
4 participants
Diff: https://author-tools.ietf.org/api/iddiff?url_1=https://oauth-wg.github.io/draft-ietf-oauth-status-list/draft-ietf-oauth-status-list.txt&url_2=https://oauth-wg.github.io/draft-ietf-oauth-status-list/editorial-fixes-kramdown/draft-ietf-oauth-status-list.txt