TCP reliable data transfer duplicated "snd.nxt" and grammar fix#258
Open
kaskales wants to merge 1 commit into
Open
TCP reliable data transfer duplicated "snd.nxt" and grammar fix#258kaskales wants to merge 1 commit into
kaskales wants to merge 1 commit into
Conversation
obonaventure
requested changes
Sep 2, 2019
obonaventure
left a comment
obonaventure
left a comment
Owner
There was a problem hiding this comment.
I think the sentence is correct because you use snd.nxt as the sequence number of the TCP segment. The second part of the sentence indicates that the snd.nxt value is incremented by the length of the payload. Maybe we should split the sentence in two parts to make it clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a duplicated "snd.nxt" variable with the incorrect conjugation of "is" which should be "are" since it's plural. I imagine one of the "snd.nxt" variables should be changed to "snd.wnd" since this segment is being sent and should be noted as such in the sending window as well.