drop the result compatibility package dependency#279
Merged
NathanReb merged 2 commits intoocaml-ppx:masterfrom Mar 28, 2024
Merged
drop the result compatibility package dependency#279NathanReb merged 2 commits intoocaml-ppx:masterfrom
result compatibility package dependency#279NathanReb merged 2 commits intoocaml-ppx:masterfrom
Conversation
sim642
reviewed
Mar 14, 2024
src_plugins/eq/ppx_deriving_eq.ml
Outdated
Comment on lines
+96
to
+97
| | true, ([%type: ([%t? ok_t], [%t? err_t]) result] | | ||
| [%type: ([%t? ok_t], [%t? err_t]) Result.result]) -> | ||
| [%type: ([%t? ok_t], [%t? err_t]) result]) -> |
Contributor
There was a problem hiding this comment.
The two cases are now the same. Same in a bunch of other plugins.
But I wonder what implications this change has because this is a fully syntactic pattern. Code which previously derived explicitly for Result.result would no longer match here and fail to derive, no?
Contributor
Author
There was a problem hiding this comment.
that's fair. I didn't catch this as it was mostly find / replace. I think it might probably be warranted to keep this case here, which is just matching on an ident Result.result. Since that doesn't re-introduce back the result dependency I think it should be reverted.
NathanReb
reviewed
Mar 27, 2024
Collaborator
NathanReb
left a comment
NathanReb
left a comment
There was a problem hiding this comment.
This looks good! I'll fix @sim642 suggestion and merge if that's fine by you @anmonteiro.
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
added a commit
to NathanReb/opam-repository
that referenced
this pull request
Apr 17, 2024
CHANGES: * Fix the unintentional removal of `Ppx_deriving_runtime.Result` in ocaml-ppx/ppx_deriving#279 ocaml-ppx/ppx_deriving#282 (@NathanReb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resultmodule was only added in OCaml 4.08:{Pervasives,Stdlib}.resulthas been added as far back as OCaml 4.03