-
Notifications
You must be signed in to change notification settings - Fork 469
test(pkg): add test for installed variable of absent packages #13751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
70 changes: 70 additions & 0 deletions
70
test/blackbox-tests/test-cases/pkg/opam-var/absent-pkg-installed.t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| Test the "installed" variable for packages not in the solution. In opam, | ||
| absent packages have installed=false. We test different syntactic contexts: | ||
| bare ident, string interpolation, and filter context. | ||
|
|
||
| $ mkrepo | ||
|
|
||
| $ mkpkg "test-installed-var" <<'EOF' | ||
| > build: [ | ||
| > [ "echo" absent:installed ] | ||
| > [ "echo" "%{absent:installed}%" ] | ||
| > [ "echo" "%{absent:installed?yes:no}%" ] | ||
| > [ "echo" "installed" ] {absent:installed} | ||
| > [ "echo" "not installed" ] {!absent:installed} | ||
| > ] | ||
| > EOF | ||
|
|
||
| $ solve test-installed-var | ||
| Solution for dune.lock: | ||
| - test-installed-var.0.0.1 | ||
|
|
||
| Currently the installed variable is left as a pform. It should resolve to | ||
| "false" at solve time (matching opam semantics): | ||
|
|
||
| $ cat dune.lock/test-installed-var.0.0.1.pkg | ||
| (version 0.0.1) | ||
|
|
||
| (build | ||
| (all_platforms | ||
| ((action | ||
| (progn | ||
| (run echo %{pkg:absent:installed}) | ||
| (run echo %{pkg:absent:installed}) | ||
| (run | ||
| echo | ||
| (if (catch_undefined_var %{pkg:absent:installed} false) yes no)) | ||
| (when %{pkg:absent:installed} (run echo installed)) | ||
| (when (not %{pkg:absent:installed}) (run echo "not installed"))))))) | ||
|
|
||
|
|
||
| The "enable" variable is desugared to "installed?enable:disable". Currently the | ||
| variable is left as a conditional. Since installed is false for absent packages, | ||
| enable should resolve to "disable" at solve time: | ||
|
|
||
| $ mkpkg "test-enable-var" <<'EOF' | ||
| > build: [ | ||
| > [ "echo" absent:enable ] | ||
| > [ "echo" "%{absent:enable}%" ] | ||
| > [ "echo" "%{absent:enable?yes:no}%" ] | ||
| > ] | ||
| > EOF | ||
|
|
||
| $ solve test-enable-var | ||
| Solution for dune.lock: | ||
| - test-enable-var.0.0.1 | ||
|
|
||
| $ cat dune.lock/test-enable-var.0.0.1.pkg | ||
| (version 0.0.1) | ||
|
|
||
| (build | ||
| (all_platforms | ||
| ((action | ||
| (progn | ||
| (run | ||
| echo | ||
| (if (catch_undefined_var %{pkg:absent:installed} false) enable disable)) | ||
| (run | ||
| echo | ||
| (if (catch_undefined_var %{pkg:absent:installed} false) enable disable)) | ||
| (run echo (if (catch_undefined_var %{pkg:absent:enable} false) yes no))))))) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.