fix(pkg): substitute installed variable at solve time#13776
Merged
Alizter merged 1 commit intoocaml:mainfrom Mar 12, 2026
Merged
fix(pkg): substitute installed variable at solve time#13776Alizter merged 1 commit intoocaml:mainfrom
installed variable at solve time#13776Alizter merged 1 commit intoocaml:mainfrom
Conversation
Alizter
force-pushed
the
push-upnkkykwmrzt
branch
from
ac42d19 to
2b36474
Compare
Alizter
force-pushed
the
push-upnkkykwmrzt
branch
from
2b36474 to
86a0cd5
Compare
Leonidas-from-XIV
previously requested changes
Mar 11, 2026
Collaborator
Leonidas-from-XIV
left a comment
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
The code looks good and seems to be covered well in tests. I have some questions on clarification and suggestions to make it more understandable for future readers.
test/blackbox-tests/test-cases/pkg/opam-var/absent-pkg-installed.t
Outdated
Show resolved
Hide resolved
Alizter
force-pushed
the
push-upnkkykwmrzt
branch
from
86a0cd5 to
24149f5
Compare
rgrinberg
approved these changes
Mar 11, 2026
When a package is absent from the solution, its 'installed' variable is known to have the value "false". We therefore substitute it at solve time. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-upnkkykwmrzt
branch
from
24149f5 to
ada8ff0
Compare
Alizter
dismissed
Leonidas-from-XIV’s stale review
dismissing so we can look at the next PR, further comments can be handled in follow up
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a package is absent from the solution, its 'installed' variable is known to have the value "false". We therefore substitute it at solve time.
Split off from #13466