Handle more class and object-related cases in the hover filtering.#1599
Merged
voodoos merged 5 commits intoocaml:masterfrom Mar 31, 2026
Merged
Handle more class and object-related cases in the hover filtering.#1599voodoos merged 5 commits intoocaml:masterfrom
voodoos merged 5 commits intoocaml:masterfrom
Conversation
Behavior is still imperfect but that's a merlin issue: type enclosing returns nothing when hovering over `c` in `class c = object ... end`
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Apr 9, 2026
CHANGES: ## Features - Add custom [`ocamllsp/refactorExtract`](https://github.com/ocaml/ocaml-lsp/blob/ocaml-lsp-server/docs/ocamllsp/refactorExtract-spec.md) request (ocaml/ocaml-lsp#1545) - Add `destruct` custom request (ocaml/ocaml-lsp#1583) - Add `locate_types` custom request (ocaml/ocaml-lsp#1584) - Add support for the `textDocument/rangeFormatting` request (ocaml/ocaml-lsp#1591) - Allow to configure merlin using build systems other than dune. If `$OCAMLLSP_PROJECT_BUILD_SYSTEM` environment variable is set then OCaml LSP will execute `$OCAMLLSP_PROJECT_BUILD_SYSTEM ocaml-merlin` command to get merlin configuration for a module. It is expected the command to communicate using `merlin-dot-protocol`. If `$OCAMLLSP_PROJECT_ROOT` environment variable is set then OCaml LSP will use it as a project root directory. ## Fixes - Enable "hover" on more locations, notably class and object related (ocaml/ocaml-lsp#1599)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Apr 9, 2026
CHANGES: ## Features - Add custom [`ocamllsp/refactorExtract`](https://github.com/ocaml/ocaml-lsp/blob/ocaml-lsp-server/docs/ocamllsp/refactorExtract-spec.md) request (ocaml/ocaml-lsp#1545) - Add `destruct` custom request (ocaml/ocaml-lsp#1583) - Add `locate_types` custom request (ocaml/ocaml-lsp#1584) - Add support for the `textDocument/rangeFormatting` request (ocaml/ocaml-lsp#1591) - Allow to configure merlin using build systems other than dune. If `$OCAMLLSP_PROJECT_BUILD_SYSTEM` environment variable is set then OCaml LSP will execute `$OCAMLLSP_PROJECT_BUILD_SYSTEM ocaml-merlin` command to get merlin configuration for a module. It is expected the command to communicate using `merlin-dot-protocol`. If `$OCAMLLSP_PROJECT_ROOT` environment variable is set then OCaml LSP will use it as a project root directory. ## Fixes - Enable "hover" on more locations, notably class and object related (ocaml/ocaml-lsp#1599)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior is still imperfect but that's a merlin issue: type enclosing returns nothing when hovering over
cinclass c = object ... endIt's a step towards fixing #1587 but there is also work needed on Merlin, some of these type-enclosing request still return nothing.
I also enabled hovering hover records's curly brackets in expressions